]> Git Repo - linux.git/commit
auxdisplay: cfag12864bfb: Convert to platform remove callback returning void
authorUwe Kleine-König <[email protected]>
Mon, 11 Mar 2024 21:59:22 +0000 (22:59 +0100)
committerAndy Shevchenko <[email protected]>
Tue, 12 Mar 2024 15:36:49 +0000 (17:36 +0200)
commit07d03559ed28e514c022e7ffd1e43705d48dee5e
treec3f4b7045dbd7adf907eae8695bc2b8ed150fb65
parentd8abf9d4ea3578e594fdde0d25d29cbabab96981
auxdisplay: cfag12864bfb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <[email protected]>
Acked-by: Miguel Ojeda <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
drivers/auxdisplay/cfag12864bfb.c
This page took 0.048518 seconds and 4 git commands to generate.