]> Git Repo - linux.git/commit
hwmon: (max1111) Change sysfs interface to in[0-3]_input in millivolts
authorEric Miao <[email protected]>
Mon, 16 Jan 2012 21:51:45 +0000 (22:51 +0100)
committerJean Delvare <[email protected]>
Mon, 16 Jan 2012 21:51:45 +0000 (22:51 +0100)
commit012f3b9118c7aaa3549f89299386f92b6580d235
tree7ee22ace6e9446c699ffa2451e03225bddc80590
parent53999bf34d55981328f8ba9def558d3e104d6e36
hwmon: (max1111) Change sysfs interface to in[0-3]_input in millivolts

This patch fixed the inconsistent max1111 sysfs interface as pointed
out by Jean Delvare:

    It was pointed to me that the max1111 driver doesn't implement the
    standard sysfs interface for hwmon drivers (as described in
    Documentation/hwmon/sysfs-interface). It exports files adc[0-3]_in,
    which
    aren't part of the standard interface. Presumably these should be
    renamed to in[0-3]_input. Renaming them is probably not sufficient
    though, as I see no scaling done in the driver. As the MAX1111 chip has
    a documented full scale of 2.048V, I take it that the LSB of the ADC
    has a weight of 8 mV. Exporting raw register values to user-space is
    not OK.

Reported-by: Jean Delvare <[email protected]>
Signed-off-by: Eric Miao <[email protected]>
Signed-off-by: Jean Delvare <[email protected]>
drivers/hwmon/max1111.c
This page took 0.068653 seconds and 4 git commands to generate.