]> Git Repo - linux.git/blobdiff - crypto/shash.c
crypto: ahash - remove support for nonzero alignmask
[linux.git] / crypto / shash.c
index 1fadb6b59bdcc1afdd61b280813249327b4025d5..359702c2cd02bf07455c4662ddf4ec0031dd5b49 100644 (file)
 #include <linux/err.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/slab.h>
 #include <linux/seq_file.h>
 #include <linux/string.h>
 #include <net/netlink.h>
 
 #include "hash.h"
 
-#define MAX_SHASH_ALIGNMASK 63
-
 static const struct crypto_type crypto_shash_type;
 
 static inline struct crypto_istat_hash *shash_get_stat(struct shash_alg *alg)
@@ -38,27 +35,6 @@ int shash_no_setkey(struct crypto_shash *tfm, const u8 *key,
 }
 EXPORT_SYMBOL_GPL(shash_no_setkey);
 
-static int shash_setkey_unaligned(struct crypto_shash *tfm, const u8 *key,
-                                 unsigned int keylen)
-{
-       struct shash_alg *shash = crypto_shash_alg(tfm);
-       unsigned long alignmask = crypto_shash_alignmask(tfm);
-       unsigned long absize;
-       u8 *buffer, *alignbuffer;
-       int err;
-
-       absize = keylen + (alignmask & ~(crypto_tfm_ctx_alignment() - 1));
-       buffer = kmalloc(absize, GFP_ATOMIC);
-       if (!buffer)
-               return -ENOMEM;
-
-       alignbuffer = (u8 *)ALIGN((unsigned long)buffer, alignmask + 1);
-       memcpy(alignbuffer, key, keylen);
-       err = shash->setkey(tfm, alignbuffer, keylen);
-       kfree_sensitive(buffer);
-       return err;
-}
-
 static void shash_set_needkey(struct crypto_shash *tfm, struct shash_alg *alg)
 {
        if (crypto_shash_alg_needs_key(alg))
@@ -69,14 +45,9 @@ int crypto_shash_setkey(struct crypto_shash *tfm, const u8 *key,
                        unsigned int keylen)
 {
        struct shash_alg *shash = crypto_shash_alg(tfm);
-       unsigned long alignmask = crypto_shash_alignmask(tfm);
        int err;
 
-       if ((unsigned long)key & alignmask)
-               err = shash_setkey_unaligned(tfm, key, keylen);
-       else
-               err = shash->setkey(tfm, key, keylen);
-
+       err = shash->setkey(tfm, key, keylen);
        if (unlikely(err)) {
                shash_set_needkey(tfm, shash);
                return err;
@@ -87,108 +58,42 @@ int crypto_shash_setkey(struct crypto_shash *tfm, const u8 *key,
 }
 EXPORT_SYMBOL_GPL(crypto_shash_setkey);
 
-static int shash_update_unaligned(struct shash_desc *desc, const u8 *data,
-                                 unsigned int len)
-{
-       struct crypto_shash *tfm = desc->tfm;
-       struct shash_alg *shash = crypto_shash_alg(tfm);
-       unsigned long alignmask = crypto_shash_alignmask(tfm);
-       unsigned int unaligned_len = alignmask + 1 -
-                                    ((unsigned long)data & alignmask);
-       /*
-        * We cannot count on __aligned() working for large values:
-        * https://patchwork.kernel.org/patch/9507697/
-        */
-       u8 ubuf[MAX_SHASH_ALIGNMASK * 2];
-       u8 *buf = PTR_ALIGN(&ubuf[0], alignmask + 1);
-       int err;
-
-       if (WARN_ON(buf + unaligned_len > ubuf + sizeof(ubuf)))
-               return -EINVAL;
-
-       if (unaligned_len > len)
-               unaligned_len = len;
-
-       memcpy(buf, data, unaligned_len);
-       err = shash->update(desc, buf, unaligned_len);
-       memset(buf, 0, unaligned_len);
-
-       return err ?:
-              shash->update(desc, data + unaligned_len, len - unaligned_len);
-}
-
 int crypto_shash_update(struct shash_desc *desc, const u8 *data,
                        unsigned int len)
 {
-       struct crypto_shash *tfm = desc->tfm;
-       struct shash_alg *shash = crypto_shash_alg(tfm);
-       unsigned long alignmask = crypto_shash_alignmask(tfm);
+       struct shash_alg *shash = crypto_shash_alg(desc->tfm);
        int err;
 
        if (IS_ENABLED(CONFIG_CRYPTO_STATS))
                atomic64_add(len, &shash_get_stat(shash)->hash_tlen);
 
-       if ((unsigned long)data & alignmask)
-               err = shash_update_unaligned(desc, data, len);
-       else
-               err = shash->update(desc, data, len);
+       err = shash->update(desc, data, len);
 
        return crypto_shash_errstat(shash, err);
 }
 EXPORT_SYMBOL_GPL(crypto_shash_update);
 
-static int shash_final_unaligned(struct shash_desc *desc, u8 *out)
-{
-       struct crypto_shash *tfm = desc->tfm;
-       unsigned long alignmask = crypto_shash_alignmask(tfm);
-       struct shash_alg *shash = crypto_shash_alg(tfm);
-       unsigned int ds = crypto_shash_digestsize(tfm);
-       /*
-        * We cannot count on __aligned() working for large values:
-        * https://patchwork.kernel.org/patch/9507697/
-        */
-       u8 ubuf[MAX_SHASH_ALIGNMASK + HASH_MAX_DIGESTSIZE];
-       u8 *buf = PTR_ALIGN(&ubuf[0], alignmask + 1);
-       int err;
-
-       if (WARN_ON(buf + ds > ubuf + sizeof(ubuf)))
-               return -EINVAL;
-
-       err = shash->final(desc, buf);
-       if (err)
-               goto out;
-
-       memcpy(out, buf, ds);
-
-out:
-       memset(buf, 0, ds);
-       return err;
-}
-
 int crypto_shash_final(struct shash_desc *desc, u8 *out)
 {
-       struct crypto_shash *tfm = desc->tfm;
-       struct shash_alg *shash = crypto_shash_alg(tfm);
-       unsigned long alignmask = crypto_shash_alignmask(tfm);
+       struct shash_alg *shash = crypto_shash_alg(desc->tfm);
        int err;
 
        if (IS_ENABLED(CONFIG_CRYPTO_STATS))
                atomic64_inc(&shash_get_stat(shash)->hash_cnt);
 
-       if ((unsigned long)out & alignmask)
-               err = shash_final_unaligned(desc, out);
-       else
-               err = shash->final(desc, out);
+       err = shash->final(desc, out);
 
        return crypto_shash_errstat(shash, err);
 }
 EXPORT_SYMBOL_GPL(crypto_shash_final);
 
-static int shash_finup_unaligned(struct shash_desc *desc, const u8 *data,
-                                unsigned int len, u8 *out)
+static int shash_default_finup(struct shash_desc *desc, const u8 *data,
+                              unsigned int len, u8 *out)
 {
-       return shash_update_unaligned(desc, data, len) ?:
-              shash_final_unaligned(desc, out);
+       struct shash_alg *shash = crypto_shash_alg(desc->tfm);
+
+       return shash->update(desc, data, len) ?:
+              shash->final(desc, out);
 }
 
 int crypto_shash_finup(struct shash_desc *desc, const u8 *data,
@@ -196,7 +101,6 @@ int crypto_shash_finup(struct shash_desc *desc, const u8 *data,
 {
        struct crypto_shash *tfm = desc->tfm;
        struct shash_alg *shash = crypto_shash_alg(tfm);
-       unsigned long alignmask = crypto_shash_alignmask(tfm);
        int err;
 
        if (IS_ENABLED(CONFIG_CRYPTO_STATS)) {
@@ -206,22 +110,19 @@ int crypto_shash_finup(struct shash_desc *desc, const u8 *data,
                atomic64_add(len, &istat->hash_tlen);
        }
 
-       if (((unsigned long)data | (unsigned long)out) & alignmask)
-               err = shash_finup_unaligned(desc, data, len, out);
-       else
-               err = shash->finup(desc, data, len, out);
-
+       err = shash->finup(desc, data, len, out);
 
        return crypto_shash_errstat(shash, err);
 }
 EXPORT_SYMBOL_GPL(crypto_shash_finup);
 
-static int shash_digest_unaligned(struct shash_desc *desc, const u8 *data,
-                                 unsigned int len, u8 *out)
+static int shash_default_digest(struct shash_desc *desc, const u8 *data,
+                               unsigned int len, u8 *out)
 {
-       return crypto_shash_init(desc) ?:
-              shash_update_unaligned(desc, data, len) ?:
-              shash_final_unaligned(desc, out);
+       struct shash_alg *shash = crypto_shash_alg(desc->tfm);
+
+       return shash->init(desc) ?:
+              shash->finup(desc, data, len, out);
 }
 
 int crypto_shash_digest(struct shash_desc *desc, const u8 *data,
@@ -229,7 +130,6 @@ int crypto_shash_digest(struct shash_desc *desc, const u8 *data,
 {
        struct crypto_shash *tfm = desc->tfm;
        struct shash_alg *shash = crypto_shash_alg(tfm);
-       unsigned long alignmask = crypto_shash_alignmask(tfm);
        int err;
 
        if (IS_ENABLED(CONFIG_CRYPTO_STATS)) {
@@ -241,8 +141,6 @@ int crypto_shash_digest(struct shash_desc *desc, const u8 *data,
 
        if (crypto_shash_get_flags(tfm) & CRYPTO_TFM_NEED_KEY)
                err = -ENOKEY;
-       else if (((unsigned long)data | (unsigned long)out) & alignmask)
-               err = shash_digest_unaligned(desc, data, len, out);
        else
                err = shash->digest(desc, data, len, out);
 
@@ -266,17 +164,34 @@ int crypto_shash_tfm_digest(struct crypto_shash *tfm, const u8 *data,
 }
 EXPORT_SYMBOL_GPL(crypto_shash_tfm_digest);
 
-static int shash_default_export(struct shash_desc *desc, void *out)
+int crypto_shash_export(struct shash_desc *desc, void *out)
 {
-       memcpy(out, shash_desc_ctx(desc), crypto_shash_descsize(desc->tfm));
+       struct crypto_shash *tfm = desc->tfm;
+       struct shash_alg *shash = crypto_shash_alg(tfm);
+
+       if (shash->export)
+               return shash->export(desc, out);
+
+       memcpy(out, shash_desc_ctx(desc), crypto_shash_descsize(tfm));
        return 0;
 }
+EXPORT_SYMBOL_GPL(crypto_shash_export);
 
-static int shash_default_import(struct shash_desc *desc, const void *in)
+int crypto_shash_import(struct shash_desc *desc, const void *in)
 {
-       memcpy(shash_desc_ctx(desc), in, crypto_shash_descsize(desc->tfm));
+       struct crypto_shash *tfm = desc->tfm;
+       struct shash_alg *shash = crypto_shash_alg(tfm);
+
+       if (crypto_shash_get_flags(tfm) & CRYPTO_TFM_NEED_KEY)
+               return -ENOKEY;
+
+       if (shash->import)
+               return shash->import(desc, in);
+
+       memcpy(shash_desc_ctx(desc), in, crypto_shash_descsize(tfm));
        return 0;
 }
+EXPORT_SYMBOL_GPL(crypto_shash_import);
 
 static int shash_async_setkey(struct crypto_ahash *tfm, const u8 *key,
                              unsigned int keylen)
@@ -626,6 +541,10 @@ int hash_prepare_alg(struct hash_alg_common *alg)
        if (alg->digestsize > HASH_MAX_DIGESTSIZE)
                return -EINVAL;
 
+       /* alignmask is not useful for hashes, so it is not supported. */
+       if (base->cra_alignmask)
+               return -EINVAL;
+
        base->cra_flags &= ~CRYPTO_ALG_TYPE_MASK;
 
        if (IS_ENABLED(CONFIG_CRYPTO_STATS))
@@ -642,9 +561,6 @@ static int shash_prepare_alg(struct shash_alg *alg)
        if (alg->descsize > HASH_MAX_DESCSIZE)
                return -EINVAL;
 
-       if (base->cra_alignmask > MAX_SHASH_ALIGNMASK)
-               return -EINVAL;
-
        if ((alg->export && !alg->import) || (alg->import && !alg->export))
                return -EINVAL;
 
@@ -655,15 +571,23 @@ static int shash_prepare_alg(struct shash_alg *alg)
        base->cra_type = &crypto_shash_type;
        base->cra_flags |= CRYPTO_ALG_TYPE_SHASH;
 
+       /*
+        * Handle missing optional functions.  For each one we can either
+        * install a default here, or we can leave the pointer as NULL and check
+        * the pointer for NULL in crypto_shash_*(), avoiding an indirect call
+        * when the default behavior is desired.  For ->finup and ->digest we
+        * install defaults, since for optimal performance algorithms should
+        * implement these anyway.  On the other hand, for ->import and
+        * ->export the common case and best performance comes from the simple
+        * memcpy of the shash_desc_ctx, so when those pointers are NULL we
+        * leave them NULL and provide the memcpy with no indirect call.
+        */
        if (!alg->finup)
-               alg->finup = shash_finup_unaligned;
+               alg->finup = shash_default_finup;
        if (!alg->digest)
-               alg->digest = shash_digest_unaligned;
-       if (!alg->export) {
-               alg->export = shash_default_export;
-               alg->import = shash_default_import;
+               alg->digest = shash_default_digest;
+       if (!alg->export)
                alg->halg.statesize = alg->descsize;
-       }
        if (!alg->setkey)
                alg->setkey = shash_no_setkey;
 
This page took 0.037366 seconds and 4 git commands to generate.