fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

[linux.git] / drivers / fpga / fpga-mgr.c

diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
index 188ffefa3cc3e25c3befebde04aec83e6c80b0fc..9939d2cbc9a6cbca56d5f3e59ce0e068146919dc 100644 (file)
--- a/drivers/fpga/fpga-mgr.c
+++ b/drivers/fpga/fpga-mgr.c
@@ -2,6 +2,7 @@
  * FPGA Manager Core
  *
  *  Copyright (C) 2013-2015 Altera Corporation
  * FPGA Manager Core
  *
  *  Copyright (C) 2013-2015 Altera Corporation

+ *  Copyright (C) 2017 Intel Corporation

  *
  * With code from the mailing list:
  * Copyright (C) 2013 Xilinx, Inc.
  *
  * With code from the mailing list:
  * Copyright (C) 2013 Xilinx, Inc.


@@ -31,6 +32,40 @@
 static DEFINE_IDA(fpga_mgr_ida);
 static struct class *fpga_mgr_class;
 
 static DEFINE_IDA(fpga_mgr_ida);
 static struct class *fpga_mgr_class;
 

+struct fpga_image_info *fpga_image_info_alloc(struct device *dev)
+{
+       struct fpga_image_info *info;
+
+       get_device(dev);
+
+       info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
+       if (!info) {
+               put_device(dev);
+               return NULL;
+       }
+
+       info->dev = dev;
+
+       return info;
+}
+EXPORT_SYMBOL_GPL(fpga_image_info_alloc);
+
+void fpga_image_info_free(struct fpga_image_info *info)
+{
+       struct device *dev;
+
+       if (!info)
+               return;
+
+       dev = info->dev;
+       if (info->firmware_name)
+               devm_kfree(dev, info->firmware_name);
+
+       devm_kfree(dev, info);
+       put_device(dev);
+}
+EXPORT_SYMBOL_GPL(fpga_image_info_free);
+

 /*
  * Call the low level driver's write_init function.  This will do the
  * device-specific things to get the FPGA into the state where it is ready to
 /*
  * Call the low level driver's write_init function.  This will do the
  * device-specific things to get the FPGA into the state where it is ready to


@@ -137,8 +172,9 @@ static int fpga_mgr_write_complete(struct fpga_manager *mgr,
  *
  * Return: 0 on success, negative error code otherwise.
  */
  *
  * Return: 0 on success, negative error code otherwise.
  */

-int fpga_mgr_buf_load_sg(struct fpga_manager *mgr, struct fpga_image_info *info,
-                        struct sg_table *sgt)
+static int fpga_mgr_buf_load_sg(struct fpga_manager *mgr,
+                               struct fpga_image_info *info,
+                               struct sg_table *sgt)

 {
        int ret;
 
 {
        int ret;
 


@@ -170,7 +206,6 @@ int fpga_mgr_buf_load_sg(struct fpga_manager *mgr, struct fpga_image_info *info,
 
        return fpga_mgr_write_complete(mgr, info);
 }
 
        return fpga_mgr_write_complete(mgr, info);
 }

-EXPORT_SYMBOL_GPL(fpga_mgr_buf_load_sg);

 
 static int fpga_mgr_buf_load_mapped(struct fpga_manager *mgr,
                                    struct fpga_image_info *info,
 
 static int fpga_mgr_buf_load_mapped(struct fpga_manager *mgr,
                                    struct fpga_image_info *info,


@@ -210,8 +245,9 @@ static int fpga_mgr_buf_load_mapped(struct fpga_manager *mgr,
  *
  * Return: 0 on success, negative error code otherwise.
  */
  *
  * Return: 0 on success, negative error code otherwise.
  */

-int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info *info,
-                     const char *buf, size_t count)
+static int fpga_mgr_buf_load(struct fpga_manager *mgr,
+                            struct fpga_image_info *info,
+                            const char *buf, size_t count)

 {
        struct page **pages;
        struct sg_table sgt;
 {
        struct page **pages;
        struct sg_table sgt;


@@ -266,7 +302,6 @@ int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info *info,
 
        return rc;
 }
 
        return rc;
 }

-EXPORT_SYMBOL_GPL(fpga_mgr_buf_load);

 
 /**
  * fpga_mgr_firmware_load - request firmware and load to fpga
 
 /**
  * fpga_mgr_firmware_load - request firmware and load to fpga


@@ -282,9 +317,9 @@ EXPORT_SYMBOL_GPL(fpga_mgr_buf_load);
  *
  * Return: 0 on success, negative error code otherwise.
  */
  *
  * Return: 0 on success, negative error code otherwise.
  */

-int fpga_mgr_firmware_load(struct fpga_manager *mgr,
-                          struct fpga_image_info *info,
-                          const char *image_name)
+static int fpga_mgr_firmware_load(struct fpga_manager *mgr,
+                                 struct fpga_image_info *info,
+                                 const char *image_name)

 {
        struct device *dev = &mgr->dev;
        const struct firmware *fw;
 {
        struct device *dev = &mgr->dev;
        const struct firmware *fw;


@@ -307,7 +342,18 @@ int fpga_mgr_firmware_load(struct fpga_manager *mgr,
 
        return ret;
 }
 
        return ret;
 }

-EXPORT_SYMBOL_GPL(fpga_mgr_firmware_load);
+
+int fpga_mgr_load(struct fpga_manager *mgr, struct fpga_image_info *info)
+{
+       if (info->sgt)
+               return fpga_mgr_buf_load_sg(mgr, info, info->sgt);
+       if (info->buf && info->count)
+               return fpga_mgr_buf_load(mgr, info, info->buf, info->count);
+       if (info->firmware_name)
+               return fpga_mgr_firmware_load(mgr, info, info->firmware_name);
+       return -EINVAL;
+}
+EXPORT_SYMBOL_GPL(fpga_mgr_load);

 
 static const char * const state_str[] = {
        [FPGA_MGR_STATE_UNKNOWN] =              "unknown",
 
 static const char * const state_str[] = {
        [FPGA_MGR_STATE_UNKNOWN] =              "unknown",


@@ -364,28 +410,17 @@ ATTRIBUTE_GROUPS(fpga_mgr);
 static struct fpga_manager *__fpga_mgr_get(struct device *dev)
 {
        struct fpga_manager *mgr;
 static struct fpga_manager *__fpga_mgr_get(struct device *dev)
 {
        struct fpga_manager *mgr;

-       int ret = -ENODEV;

 
        mgr = to_fpga_manager(dev);
 
        mgr = to_fpga_manager(dev);

-       if (!mgr)
-               goto err_dev;
-
-       /* Get exclusive use of fpga manager */
-       if (!mutex_trylock(&mgr->ref_mutex)) {
-               ret = -EBUSY;
-               goto err_dev;
-       }

 
        if (!try_module_get(dev->parent->driver->owner))
 
        if (!try_module_get(dev->parent->driver->owner))

-               goto err_ll_mod;
+               goto err_dev;

 
        return mgr;
 
 
        return mgr;
 

-err_ll_mod:
-       mutex_unlock(&mgr->ref_mutex);

 err_dev:
        put_device(dev);
 err_dev:
        put_device(dev);

-       return ERR_PTR(ret);
+       return ERR_PTR(-ENODEV);

 }
 
 static int fpga_mgr_dev_match(struct device *dev, const void *data)
 }
 
 static int fpga_mgr_dev_match(struct device *dev, const void *data)


@@ -394,10 +429,10 @@ static int fpga_mgr_dev_match(struct device *dev, const void *data)
 }
 
 /**
 }
 
 /**

- * fpga_mgr_get - get an exclusive reference to a fpga mgr
+ * fpga_mgr_get - get a reference to a fpga mgr

  * @dev:       parent device that fpga mgr was registered with
  *
  * @dev:       parent device that fpga mgr was registered with
  *

- * Given a device, get an exclusive reference to a fpga mgr.
+ * Given a device, get a reference to a fpga mgr.

  *
  * Return: fpga manager struct or IS_ERR() condition containing error code.
  */
  *
  * Return: fpga manager struct or IS_ERR() condition containing error code.
  */


@@ -418,10 +453,10 @@ static int fpga_mgr_of_node_match(struct device *dev, const void *data)
 }
 
 /**
 }
 
 /**

- * of_fpga_mgr_get - get an exclusive reference to a fpga mgr
+ * of_fpga_mgr_get - get a reference to a fpga mgr

  * @node:      device node
  *
  * @node:      device node
  *

- * Given a device node, get an exclusive reference to a fpga mgr.
+ * Given a device node, get a reference to a fpga mgr.

  *
  * Return: fpga manager struct or IS_ERR() condition containing error code.
  */
  *
  * Return: fpga manager struct or IS_ERR() condition containing error code.
  */


@@ -445,11 +480,40 @@ EXPORT_SYMBOL_GPL(of_fpga_mgr_get);
 void fpga_mgr_put(struct fpga_manager *mgr)
 {
        module_put(mgr->dev.parent->driver->owner);
 void fpga_mgr_put(struct fpga_manager *mgr)
 {
        module_put(mgr->dev.parent->driver->owner);

-       mutex_unlock(&mgr->ref_mutex);

        put_device(&mgr->dev);
 }
 EXPORT_SYMBOL_GPL(fpga_mgr_put);
 
        put_device(&mgr->dev);
 }
 EXPORT_SYMBOL_GPL(fpga_mgr_put);
 

+/**
+ * fpga_mgr_lock - Lock FPGA manager for exclusive use
+ * @mgr:       fpga manager
+ *
+ * Given a pointer to FPGA Manager (from fpga_mgr_get() or
+ * of_fpga_mgr_put()) attempt to get the mutex.
+ *
+ * Return: 0 for success or -EBUSY
+ */
+int fpga_mgr_lock(struct fpga_manager *mgr)
+{
+       if (!mutex_trylock(&mgr->ref_mutex)) {
+               dev_err(&mgr->dev, "FPGA manager is in use.\n");
+               return -EBUSY;
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(fpga_mgr_lock);
+
+/**
+ * fpga_mgr_unlock - Unlock FPGA manager
+ * @mgr:       fpga manager
+ */
+void fpga_mgr_unlock(struct fpga_manager *mgr)
+{
+       mutex_unlock(&mgr->ref_mutex);
+}
+EXPORT_SYMBOL_GPL(fpga_mgr_unlock);
+

 /**
  * fpga_mgr_register - register a low level fpga manager driver
  * @dev:       fpga manager device from pdev
 /**
  * fpga_mgr_register - register a low level fpga manager driver
  * @dev:       fpga manager device from pdev


@@ -503,6 +567,7 @@ int fpga_mgr_register(struct device *dev, const char *name,
 
        device_initialize(&mgr->dev);
        mgr->dev.class = fpga_mgr_class;
 
        device_initialize(&mgr->dev);
        mgr->dev.class = fpga_mgr_class;

+       mgr->dev.groups = mops->groups;

        mgr->dev.parent = dev;
        mgr->dev.of_node = dev->of_node;
        mgr->dev.id = id;
        mgr->dev.parent = dev;
        mgr->dev.of_node = dev->of_node;
        mgr->dev.id = id;


@@ -578,7 +643,7 @@ static void __exit fpga_mgr_class_exit(void)
        ida_destroy(&fpga_mgr_ida);
 }
 
        ida_destroy(&fpga_mgr_ida);
 }
 

-MODULE_AUTHOR("Alan Tull <atull@opensource.altera.com>");
+MODULE_AUTHOR("Alan Tull <atull@kernel.org>");

 MODULE_DESCRIPTION("FPGA manager framework");
 MODULE_LICENSE("GPL v2");
 
 MODULE_DESCRIPTION("FPGA manager framework");
 MODULE_LICENSE("GPL v2");