]> Git Repo - linux.git/blame - net/mac80211/agg-tx.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
[linux.git] / net / mac80211 / agg-tx.c
CommitLineData
d2912cb1 1// SPDX-License-Identifier: GPL-2.0-only
b8695a8f
JB
2/*
3 * HT handling
4 *
5 * Copyright 2003, Jouni Malinen <[email protected]>
6 * Copyright 2002-2005, Instant802 Networks, Inc.
7 * Copyright 2005-2006, Devicescape Software, Inc.
8 * Copyright 2006-2007 Jiri Benc <[email protected]>
9 * Copyright 2007, Michael Wu <[email protected]>
cfcdbde3 10 * Copyright 2007-2010, Intel Corporation
7a7c0a64 11 * Copyright(c) 2015-2017 Intel Deutschland GmbH
6157ca0d 12 * Copyright (C) 2018 - 2019 Intel Corporation
b8695a8f
JB
13 */
14
15#include <linux/ieee80211.h>
5a0e3ad6 16#include <linux/slab.h>
bc3b2d7f 17#include <linux/export.h>
b8695a8f
JB
18#include <net/mac80211.h>
19#include "ieee80211_i.h"
24487981 20#include "driver-ops.h"
b8695a8f
JB
21#include "wme.h"
22
86ab6c5a 23/**
73a72a81 24 * DOC: TX A-MPDU aggregation
86ab6c5a
JB
25 *
26 * Aggregation on the TX side requires setting the hardware flag
73a72a81
JB
27 * %IEEE80211_HW_AMPDU_AGGREGATION. The driver will then be handed
28 * packets with a flag indicating A-MPDU aggregation. The driver
29 * or device is responsible for actually aggregating the frames,
30 * as well as deciding how many and which to aggregate.
86ab6c5a 31 *
73a72a81
JB
32 * When TX aggregation is started by some subsystem (usually the rate
33 * control algorithm would be appropriate) by calling the
34 * ieee80211_start_tx_ba_session() function, the driver will be
35 * notified via its @ampdu_action function, with the
36 * %IEEE80211_AMPDU_TX_START action.
86ab6c5a
JB
37 *
38 * In response to that, the driver is later required to call the
73a72a81
JB
39 * ieee80211_start_tx_ba_cb_irqsafe() function, which will really
40 * start the aggregation session after the peer has also responded.
41 * If the peer responds negatively, the session will be stopped
42 * again right away. Note that it is possible for the aggregation
43 * session to be stopped before the driver has indicated that it
44 * is done setting it up, in which case it must not indicate the
45 * setup completion.
86ab6c5a 46 *
73a72a81
JB
47 * Also note that, since we also need to wait for a response from
48 * the peer, the driver is notified of the completion of the
49 * handshake by the %IEEE80211_AMPDU_TX_OPERATIONAL action to the
50 * @ampdu_action callback.
51 *
52 * Similarly, when the aggregation session is stopped by the peer
53 * or something calling ieee80211_stop_tx_ba_session(), the driver's
54 * @ampdu_action function will be called with the action
55 * %IEEE80211_AMPDU_TX_STOP. In this case, the call must not fail,
56 * and the driver must later call ieee80211_stop_tx_ba_cb_irqsafe().
42624d49
YAP
57 * Note that the sta can get destroyed before the BA tear down is
58 * complete.
86ab6c5a
JB
59 */
60
b8695a8f
JB
61static void ieee80211_send_addba_request(struct ieee80211_sub_if_data *sdata,
62 const u8 *da, u16 tid,
63 u8 dialog_token, u16 start_seq_num,
64 u16 agg_size, u16 timeout)
65{
66 struct ieee80211_local *local = sdata->local;
b8695a8f
JB
67 struct sk_buff *skb;
68 struct ieee80211_mgmt *mgmt;
69 u16 capab;
70
71 skb = dev_alloc_skb(sizeof(*mgmt) + local->hw.extra_tx_headroom);
72
d15b8459 73 if (!skb)
b8695a8f 74 return;
d15b8459 75
b8695a8f 76 skb_reserve(skb, local->hw.extra_tx_headroom);
b080db58 77 mgmt = skb_put_zero(skb, 24);
b8695a8f 78 memcpy(mgmt->da, da, ETH_ALEN);
47846c9b 79 memcpy(mgmt->sa, sdata->vif.addr, ETH_ALEN);
8abd3f9b 80 if (sdata->vif.type == NL80211_IFTYPE_AP ||
ae2772b3
TP
81 sdata->vif.type == NL80211_IFTYPE_AP_VLAN ||
82 sdata->vif.type == NL80211_IFTYPE_MESH_POINT)
47846c9b 83 memcpy(mgmt->bssid, sdata->vif.addr, ETH_ALEN);
46900298
JB
84 else if (sdata->vif.type == NL80211_IFTYPE_STATION)
85 memcpy(mgmt->bssid, sdata->u.mgd.bssid, ETH_ALEN);
13c40c54
AS
86 else if (sdata->vif.type == NL80211_IFTYPE_ADHOC)
87 memcpy(mgmt->bssid, sdata->u.ibss.bssid, ETH_ALEN);
b8695a8f
JB
88
89 mgmt->frame_control = cpu_to_le16(IEEE80211_FTYPE_MGMT |
90 IEEE80211_STYPE_ACTION);
91
92 skb_put(skb, 1 + sizeof(mgmt->u.action.u.addba_req));
93
94 mgmt->u.action.category = WLAN_CATEGORY_BACK;
95 mgmt->u.action.u.addba_req.action_code = WLAN_ACTION_ADDBA_REQ;
96
97 mgmt->u.action.u.addba_req.dialog_token = dialog_token;
e3abc8ff
EG
98 capab = (u16)(1 << 0); /* bit 0 A-MSDU support */
99 capab |= (u16)(1 << 1); /* bit 1 aggregation policy */
b8695a8f
JB
100 capab |= (u16)(tid << 2); /* bit 5:2 TID number */
101 capab |= (u16)(agg_size << 6); /* bit 15:6 max size of aggergation */
102
103 mgmt->u.action.u.addba_req.capab = cpu_to_le16(capab);
104
105 mgmt->u.action.u.addba_req.timeout = cpu_to_le16(timeout);
106 mgmt->u.action.u.addba_req.start_seq_num =
107 cpu_to_le16(start_seq_num << 4);
108
c6e13327 109 ieee80211_tx_skb(sdata, skb);
b8695a8f
JB
110}
111
8c771244 112void ieee80211_send_bar(struct ieee80211_vif *vif, u8 *ra, u16 tid, u16 ssn)
b8695a8f 113{
8c771244 114 struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif);
b8695a8f
JB
115 struct ieee80211_local *local = sdata->local;
116 struct sk_buff *skb;
117 struct ieee80211_bar *bar;
118 u16 bar_control = 0;
119
120 skb = dev_alloc_skb(sizeof(*bar) + local->hw.extra_tx_headroom);
d15b8459 121 if (!skb)
b8695a8f 122 return;
d15b8459 123
b8695a8f 124 skb_reserve(skb, local->hw.extra_tx_headroom);
b080db58 125 bar = skb_put_zero(skb, sizeof(*bar));
b8695a8f
JB
126 bar->frame_control = cpu_to_le16(IEEE80211_FTYPE_CTL |
127 IEEE80211_STYPE_BACK_REQ);
128 memcpy(bar->ra, ra, ETH_ALEN);
47846c9b 129 memcpy(bar->ta, sdata->vif.addr, ETH_ALEN);
b8695a8f
JB
130 bar_control |= (u16)IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL;
131 bar_control |= (u16)IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA;
c1407b6c 132 bar_control |= (u16)(tid << IEEE80211_BAR_CTRL_TID_INFO_SHIFT);
b8695a8f
JB
133 bar->control = cpu_to_le16(bar_control);
134 bar->start_seq_num = cpu_to_le16(ssn);
135
2f7916f8
CL
136 IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT |
137 IEEE80211_TX_CTL_REQ_TX_STATUS;
cf6bb79a 138 ieee80211_tx_skb_tid(sdata, skb, tid);
b8695a8f 139}
8c771244 140EXPORT_SYMBOL(ieee80211_send_bar);
b8695a8f 141
ec034b20
JB
142void ieee80211_assign_tid_tx(struct sta_info *sta, int tid,
143 struct tid_ampdu_tx *tid_tx)
144{
145 lockdep_assert_held(&sta->ampdu_mlme.mtx);
146 lockdep_assert_held(&sta->lock);
147 rcu_assign_pointer(sta->ampdu_mlme.tid_tx[tid], tid_tx);
148}
149
30bf5f1f
JB
150/*
151 * When multiple aggregation sessions on multiple stations
152 * are being created/destroyed simultaneously, we need to
153 * refcount the global queue stop caused by that in order
154 * to not get into a situation where one of the aggregation
155 * setup or teardown re-enables queues before the other is
156 * ready to handle that.
157 *
158 * These two functions take care of this issue by keeping
159 * a global "agg_queue_stop" refcount.
160 */
161static void __acquires(agg_queue)
162ieee80211_stop_queue_agg(struct ieee80211_sub_if_data *sdata, int tid)
163{
164 int queue = sdata->vif.hw_queue[ieee80211_ac_from_tid(tid)];
165
cca07b00
LC
166 /* we do refcounting here, so don't use the queue reason refcounting */
167
30bf5f1f
JB
168 if (atomic_inc_return(&sdata->local->agg_queue_stop[queue]) == 1)
169 ieee80211_stop_queue_by_reason(
170 &sdata->local->hw, queue,
cca07b00
LC
171 IEEE80211_QUEUE_STOP_REASON_AGGREGATION,
172 false);
30bf5f1f
JB
173 __acquire(agg_queue);
174}
175
176static void __releases(agg_queue)
177ieee80211_wake_queue_agg(struct ieee80211_sub_if_data *sdata, int tid)
178{
179 int queue = sdata->vif.hw_queue[ieee80211_ac_from_tid(tid)];
180
181 if (atomic_dec_return(&sdata->local->agg_queue_stop[queue]) == 0)
182 ieee80211_wake_queue_by_reason(
183 &sdata->local->hw, queue,
cca07b00
LC
184 IEEE80211_QUEUE_STOP_REASON_AGGREGATION,
185 false);
30bf5f1f
JB
186 __release(agg_queue);
187}
188
ba8c3d6f
FF
189static void
190ieee80211_agg_stop_txq(struct sta_info *sta, int tid)
191{
192 struct ieee80211_txq *txq = sta->sta.txq[tid];
fa962b92
MK
193 struct ieee80211_sub_if_data *sdata;
194 struct fq *fq;
ba8c3d6f
FF
195 struct txq_info *txqi;
196
197 if (!txq)
198 return;
199
200 txqi = to_txq_info(txq);
fa962b92
MK
201 sdata = vif_to_sdata(txq->vif);
202 fq = &sdata->local->fq;
ba8c3d6f
FF
203
204 /* Lock here to protect against further seqno updates on dequeue */
fa962b92 205 spin_lock_bh(&fq->lock);
ba8c3d6f 206 set_bit(IEEE80211_TXQ_STOP, &txqi->flags);
fa962b92 207 spin_unlock_bh(&fq->lock);
ba8c3d6f
FF
208}
209
210static void
211ieee80211_agg_start_txq(struct sta_info *sta, int tid, bool enable)
212{
213 struct ieee80211_txq *txq = sta->sta.txq[tid];
214 struct txq_info *txqi;
215
216 if (!txq)
217 return;
218
219 txqi = to_txq_info(txq);
220
221 if (enable)
222 set_bit(IEEE80211_TXQ_AMPDU, &txqi->flags);
223 else
224 clear_bit(IEEE80211_TXQ_AMPDU, &txqi->flags);
225
226 clear_bit(IEEE80211_TXQ_STOP, &txqi->flags);
979e1f08
JB
227 local_bh_disable();
228 rcu_read_lock();
18667600 229 schedule_and_wake_txq(sta->sdata->local, txqi);
979e1f08
JB
230 rcu_read_unlock();
231 local_bh_enable();
ba8c3d6f
FF
232}
233
30bf5f1f
JB
234/*
235 * splice packets from the STA's pending to the local pending,
236 * requires a call to ieee80211_agg_splice_finish later
237 */
238static void __acquires(agg_queue)
239ieee80211_agg_splice_packets(struct ieee80211_sub_if_data *sdata,
240 struct tid_ampdu_tx *tid_tx, u16 tid)
241{
242 struct ieee80211_local *local = sdata->local;
243 int queue = sdata->vif.hw_queue[ieee80211_ac_from_tid(tid)];
244 unsigned long flags;
245
246 ieee80211_stop_queue_agg(sdata, tid);
247
248 if (WARN(!tid_tx,
249 "TID %d gone but expected when splicing aggregates from the pending queue\n",
250 tid))
251 return;
252
253 if (!skb_queue_empty(&tid_tx->pending)) {
254 spin_lock_irqsave(&local->queue_stop_reason_lock, flags);
255 /* copy over remaining packets */
256 skb_queue_splice_tail_init(&tid_tx->pending,
257 &local->pending[queue]);
258 spin_unlock_irqrestore(&local->queue_stop_reason_lock, flags);
259 }
260}
261
262static void __releases(agg_queue)
263ieee80211_agg_splice_finish(struct ieee80211_sub_if_data *sdata, u16 tid)
264{
265 ieee80211_wake_queue_agg(sdata, tid);
266}
267
268static void ieee80211_remove_tid_tx(struct sta_info *sta, int tid)
269{
270 struct tid_ampdu_tx *tid_tx;
271
272 lockdep_assert_held(&sta->ampdu_mlme.mtx);
273 lockdep_assert_held(&sta->lock);
274
275 tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
276
277 /*
278 * When we get here, the TX path will not be lockless any more wrt.
279 * aggregation, since the OPERATIONAL bit has long been cleared.
280 * Thus it will block on getting the lock, if it occurs. So if we
281 * stop the queue now, we will not get any more packets, and any
282 * that might be being processed will wait for us here, thereby
283 * guaranteeing that no packets go to the tid_tx pending queue any
284 * more.
285 */
286
287 ieee80211_agg_splice_packets(sta->sdata, tid_tx, tid);
288
289 /* future packets must not find the tid_tx struct any more */
290 ieee80211_assign_tid_tx(sta, tid, NULL);
291
292 ieee80211_agg_splice_finish(sta->sdata, tid);
ba8c3d6f 293 ieee80211_agg_start_txq(sta, tid, false);
30bf5f1f
JB
294
295 kfree_rcu(tid_tx, rcu_head);
296}
297
67c282c0 298int ___ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid,
c82c4a80 299 enum ieee80211_agg_stop_reason reason)
23e6a7ea 300{
849b7967 301 struct ieee80211_local *local = sta->local;
40b275b6 302 struct tid_ampdu_tx *tid_tx;
50ea05ef
SS
303 struct ieee80211_ampdu_params params = {
304 .sta = &sta->sta,
305 .tid = tid,
306 .buf_size = 0,
307 .amsdu = false,
308 .timeout = 0,
309 .ssn = 0,
310 };
23e6a7ea 311 int ret;
a622ab72 312
cfcdbde3 313 lockdep_assert_held(&sta->ampdu_mlme.mtx);
a622ab72 314
18b559d5
JB
315 switch (reason) {
316 case AGG_STOP_DECLINED:
317 case AGG_STOP_LOCAL_REQUEST:
318 case AGG_STOP_PEER_REQUEST:
50ea05ef 319 params.action = IEEE80211_AMPDU_TX_STOP_CONT;
18b559d5
JB
320 break;
321 case AGG_STOP_DESTROY_STA:
50ea05ef 322 params.action = IEEE80211_AMPDU_TX_STOP_FLUSH;
18b559d5
JB
323 break;
324 default:
325 WARN_ON_ONCE(1);
326 return -EINVAL;
327 }
328
cfcdbde3
JB
329 spin_lock_bh(&sta->lock);
330
33ddd81e
JB
331 /* free struct pending for start, if present */
332 tid_tx = sta->ampdu_mlme.tid_start_tx[tid];
333 kfree(tid_tx);
334 sta->ampdu_mlme.tid_start_tx[tid] = NULL;
335
40b275b6
JB
336 tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
337 if (!tid_tx) {
338 spin_unlock_bh(&sta->lock);
339 return -ENOENT;
340 }
341
18b559d5
JB
342 /*
343 * if we're already stopping ignore any new requests to stop
344 * unless we're destroying it in which case notify the driver
345 */
24f50a9d
JB
346 if (test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) {
347 spin_unlock_bh(&sta->lock);
18b559d5
JB
348 if (reason != AGG_STOP_DESTROY_STA)
349 return -EALREADY;
50ea05ef
SS
350 params.action = IEEE80211_AMPDU_TX_STOP_FLUSH_CONT;
351 ret = drv_ampdu_action(local, sta->sdata, &params);
18b559d5 352 WARN_ON_ONCE(ret);
8147dc7f 353 return 0;
24f50a9d
JB
354 }
355
0ab33703
JB
356 if (test_bit(HT_AGG_STATE_WANT_START, &tid_tx->state)) {
357 /* not even started yet! */
ec034b20 358 ieee80211_assign_tid_tx(sta, tid, NULL);
cfcdbde3 359 spin_unlock_bh(&sta->lock);
0744371a 360 kfree_rcu(tid_tx, rcu_head);
0ab33703
JB
361 return 0;
362 }
363
24f50a9d
JB
364 set_bit(HT_AGG_STATE_STOPPING, &tid_tx->state);
365
6157ca0d
IP
366 ieee80211_agg_stop_txq(sta, tid);
367
cfcdbde3
JB
368 spin_unlock_bh(&sta->lock);
369
bdcbd8e0
JB
370 ht_dbg(sta->sdata, "Tx BA session stop requested for %pM tid %u\n",
371 sta->sta.addr, tid);
827d42c9 372
44271488 373 del_timer_sync(&tid_tx->addba_resp_timer);
285fa695 374 del_timer_sync(&tid_tx->session_timer);
44271488 375
a622ab72
JB
376 /*
377 * After this packets are no longer handed right through
378 * to the driver but are put onto tid_tx->pending instead,
379 * with locking to ensure proper access.
380 */
381 clear_bit(HT_AGG_STATE_OPERATIONAL, &tid_tx->state);
736708bd 382
2a1e0fd1
EG
383 /*
384 * There might be a few packets being processed right now (on
385 * another CPU) that have already gotten past the aggregation
386 * check when it was still OPERATIONAL and consequently have
387 * IEEE80211_TX_CTL_AMPDU set. In that case, this code might
388 * call into the driver at the same time or even before the
389 * TX paths calls into it, which could confuse the driver.
390 *
391 * Wait for all currently running TX paths to finish before
392 * telling the driver. New packets will not go through since
393 * the aggregation session is no longer OPERATIONAL.
394 */
2316380f
SS
395 if (!local->in_reconfig)
396 synchronize_net();
2a1e0fd1 397
c82c4a80
JB
398 tid_tx->stop_initiator = reason == AGG_STOP_PEER_REQUEST ?
399 WLAN_BACK_RECIPIENT :
400 WLAN_BACK_INITIATOR;
401 tid_tx->tx_stop = reason == AGG_STOP_LOCAL_REQUEST;
23e6a7ea 402
50ea05ef 403 ret = drv_ampdu_action(local, sta->sdata, &params);
23e6a7ea
JB
404
405 /* HW shall not deny going back to legacy */
406 if (WARN_ON(ret)) {
cd8ffc80
JB
407 /*
408 * We may have pending packets get stuck in this case...
409 * Not bothering with a workaround for now.
410 */
23e6a7ea
JB
411 }
412
8147dc7f
JB
413 /*
414 * In the case of AGG_STOP_DESTROY_STA, the driver won't
415 * necessarily call ieee80211_stop_tx_ba_cb(), so this may
416 * seem like we can leave the tid_tx data pending forever.
417 * This is true, in a way, but "forever" is only until the
418 * station struct is actually destroyed. In the meantime,
419 * leaving it around ensures that we don't transmit packets
420 * to the driver on this TID which might confuse it.
421 */
18b559d5
JB
422
423 return 0;
23e6a7ea
JB
424}
425
b8695a8f
JB
426/*
427 * After sending add Block Ack request we activated a timer until
428 * add Block Ack response will arrive from the recipient.
429 * If this timer expires sta_addba_resp_timer_expired will be executed.
430 */
7cca2acd 431static void sta_addba_resp_timer_expired(struct timer_list *t)
b8695a8f 432{
d559e303
JB
433 struct tid_ampdu_tx *tid_tx = from_timer(tid_tx, t, addba_resp_timer);
434 struct sta_info *sta = tid_tx->sta;
435 u8 tid = tid_tx->tid;
23e6a7ea 436
b8695a8f 437 /* check if the TID waits for addBA response */
d559e303 438 if (test_bit(HT_AGG_STATE_RESPONSE_RECEIVED, &tid_tx->state)) {
bdcbd8e0 439 ht_dbg(sta->sdata,
d81b0fd0 440 "timer expired on %pM tid %d not expecting addBA response\n",
0a214d3f 441 sta->sta.addr, tid);
23e6a7ea 442 return;
b8695a8f
JB
443 }
444
0a214d3f
JB
445 ht_dbg(sta->sdata, "addBA response timer expired on %pM tid %d\n",
446 sta->sta.addr, tid);
b8695a8f 447
83a5cbf7 448 ieee80211_stop_tx_ba_session(&sta->sta, tid);
b8695a8f
JB
449}
450
67c282c0 451void ieee80211_tx_ba_session_handle_start(struct sta_info *sta, int tid)
0ab33703 452{
40b275b6 453 struct tid_ampdu_tx *tid_tx;
0ab33703
JB
454 struct ieee80211_local *local = sta->local;
455 struct ieee80211_sub_if_data *sdata = sta->sdata;
50ea05ef
SS
456 struct ieee80211_ampdu_params params = {
457 .sta = &sta->sta,
458 .action = IEEE80211_AMPDU_TX_START,
459 .tid = tid,
460 .buf_size = 0,
461 .amsdu = false,
462 .timeout = 0,
463 };
0ab33703 464 int ret;
41cbb0f5 465 u16 buf_size;
0ab33703 466
40b275b6 467 tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
cfcdbde3 468
0ab33703 469 /*
15062e6a
JB
470 * Start queuing up packets for this aggregation session.
471 * We're going to release them once the driver is OK with
472 * that.
0ab33703 473 */
0ab33703
JB
474 clear_bit(HT_AGG_STATE_WANT_START, &tid_tx->state);
475
ba8c3d6f
FF
476 ieee80211_agg_stop_txq(sta, tid);
477
0ab33703 478 /*
15062e6a
JB
479 * Make sure no packets are being processed. This ensures that
480 * we have a valid starting sequence number and that in-flight
481 * packets have been flushed out and no packets for this TID
482 * will go into the driver during the ampdu_action call.
0ab33703 483 */
cfcdbde3
JB
484 synchronize_net();
485
50ea05ef
SS
486 params.ssn = sta->tid_seq[tid] >> 4;
487 ret = drv_ampdu_action(local, sdata, &params);
0ab33703 488 if (ret) {
bdcbd8e0 489 ht_dbg(sdata,
0a214d3f
JB
490 "BA request denied - HW unavailable for %pM tid %d\n",
491 sta->sta.addr, tid);
cfcdbde3 492 spin_lock_bh(&sta->lock);
3a25a8c8 493 ieee80211_agg_splice_packets(sdata, tid_tx, tid);
ec034b20 494 ieee80211_assign_tid_tx(sta, tid, NULL);
3a25a8c8 495 ieee80211_agg_splice_finish(sdata, tid);
cfcdbde3
JB
496 spin_unlock_bh(&sta->lock);
497
ba8c3d6f
FF
498 ieee80211_agg_start_txq(sta, tid, false);
499
0744371a 500 kfree_rcu(tid_tx, rcu_head);
0ab33703
JB
501 return;
502 }
503
0ab33703
JB
504 /* activate the timer for the recipient's addBA response */
505 mod_timer(&tid_tx->addba_resp_timer, jiffies + ADDBA_RESP_INTERVAL);
0a214d3f
JB
506 ht_dbg(sdata, "activated addBA response timer on %pM tid %d\n",
507 sta->sta.addr, tid);
0ab33703 508
cfcdbde3 509 spin_lock_bh(&sta->lock);
84381b4e 510 sta->ampdu_mlme.last_addba_req_time[tid] = jiffies;
0ab33703 511 sta->ampdu_mlme.addba_req_num[tid]++;
cfcdbde3 512 spin_unlock_bh(&sta->lock);
0ab33703 513
41cbb0f5
LC
514 if (sta->sta.he_cap.has_he) {
515 buf_size = local->hw.max_tx_aggregation_subframes;
516 } else {
517 /*
518 * We really should use what the driver told us it will
519 * transmit as the maximum, but certain APs (e.g. the
520 * LinkSys WRT120N with FW v1.0.07 build 002 Jun 18 2012)
521 * will crash when we use a lower number.
522 */
523 buf_size = IEEE80211_MAX_AMPDU_BUF_HT;
524 }
525
0ab33703
JB
526 /* send AddBA request */
527 ieee80211_send_addba_request(sdata, sta->sta.addr, tid,
50ea05ef 528 tid_tx->dialog_token, params.ssn,
41cbb0f5 529 buf_size, tid_tx->timeout);
0ab33703
JB
530}
531
285fa695
NM
532/*
533 * After accepting the AddBA Response we activated a timer,
534 * resetting it after each frame that we send.
535 */
7cca2acd 536static void sta_tx_agg_session_timer_expired(struct timer_list *t)
285fa695 537{
d559e303
JB
538 struct tid_ampdu_tx *tid_tx = from_timer(tid_tx, t, session_timer);
539 struct sta_info *sta = tid_tx->sta;
540 u8 tid = tid_tx->tid;
12d3952f
FF
541 unsigned long timeout;
542
d559e303 543 if (test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) {
12d3952f 544 return;
9e73dee7 545 }
12d3952f
FF
546
547 timeout = tid_tx->last_tx + TU_TO_JIFFIES(tid_tx->timeout);
548 if (time_is_after_jiffies(timeout)) {
549 mod_timer(&tid_tx->session_timer, timeout);
550 return;
551 }
285fa695 552
0a214d3f 553 ht_dbg(sta->sdata, "tx session timer expired on %pM tid %d\n",
7cca2acd 554 sta->sta.addr, tid);
285fa695 555
7cca2acd 556 ieee80211_stop_tx_ba_session(&sta->sta, tid);
285fa695
NM
557}
558
bd2ce6e4
SM
559int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
560 u16 timeout)
b8695a8f 561{
c951ad35
JB
562 struct sta_info *sta = container_of(pubsta, struct sta_info, sta);
563 struct ieee80211_sub_if_data *sdata = sta->sdata;
564 struct ieee80211_local *local = sdata->local;
a622ab72 565 struct tid_ampdu_tx *tid_tx;
e4e72fb4 566 int ret = 0;
b8695a8f 567
8f9c77fc
JB
568 trace_api_start_tx_ba_session(pubsta, tid);
569
b6da911b
LK
570 if (WARN(sta->reserved_tid == tid,
571 "Requested to start BA session on reserved tid=%d", tid))
572 return -EINVAL;
573
8f9c77fc
JB
574 if (!pubsta->ht_cap.ht_supported)
575 return -EINVAL;
b5878a2d 576
50c16e22 577 if (WARN_ON_ONCE(!local->ops->ampdu_action))
23e6a7ea
JB
578 return -EINVAL;
579
5a306f58 580 if ((tid >= IEEE80211_NUM_TIDS) ||
30686bf7
JB
581 !ieee80211_hw_check(&local->hw, AMPDU_AGGREGATION) ||
582 ieee80211_hw_check(&local->hw, TX_AMPDU_SETUP_IN_HW))
b8695a8f
JB
583 return -EINVAL;
584
85d5313e
JB
585 if (WARN_ON(tid >= IEEE80211_FIRST_TSPEC_TSID))
586 return -EINVAL;
587
bdcbd8e0
JB
588 ht_dbg(sdata, "Open BA session requested for %pM tid %u\n",
589 pubsta->addr, tid);
b8695a8f 590
c951ad35 591 if (sdata->vif.type != NL80211_IFTYPE_STATION &&
ae2772b3 592 sdata->vif.type != NL80211_IFTYPE_MESH_POINT &&
c951ad35 593 sdata->vif.type != NL80211_IFTYPE_AP_VLAN &&
13c40c54
AS
594 sdata->vif.type != NL80211_IFTYPE_AP &&
595 sdata->vif.type != NL80211_IFTYPE_ADHOC)
c951ad35 596 return -EINVAL;
8abd3f9b 597
c2c98fde 598 if (test_sta_flag(sta, WLAN_STA_BLOCK_BA)) {
bdcbd8e0 599 ht_dbg(sdata,
0a214d3f
JB
600 "BA sessions blocked - Denying BA session request %pM tid %d\n",
601 sta->sta.addr, tid);
c951ad35 602 return -EINVAL;
722f069a
S
603 }
604
ff3cc5f4
SW
605 /*
606 * 802.11n-2009 11.5.1.1: If the initiating STA is an HT STA, is a
607 * member of an IBSS, and has no other existing Block Ack agreement
608 * with the recipient STA, then the initiating STA shall transmit a
609 * Probe Request frame to the recipient STA and shall not transmit an
610 * ADDBA Request frame unless it receives a Probe Response frame
611 * from the recipient within dot11ADDBAFailureTimeout.
612 *
613 * The probe request mechanism for ADDBA is currently not implemented,
614 * but we only build up Block Ack session with HT STAs. This information
615 * is set when we receive a bss info from a probe response or a beacon.
616 */
617 if (sta->sdata->vif.type == NL80211_IFTYPE_ADHOC &&
618 !sta->sta.ht_cap.ht_supported) {
bdcbd8e0
JB
619 ht_dbg(sdata,
620 "BA request denied - IBSS STA %pM does not advertise HT support\n",
621 pubsta->addr);
ff3cc5f4
SW
622 return -EINVAL;
623 }
624
b8695a8f
JB
625 spin_lock_bh(&sta->lock);
626
627 /* we have tried too many times, receiver does not want A-MPDU */
628 if (sta->ampdu_mlme.addba_req_num[tid] > HT_AGG_MAX_RETRIES) {
629 ret = -EBUSY;
84381b4e
NM
630 goto err_unlock_sta;
631 }
632
633 /*
634 * if we have tried more than HT_AGG_BURST_RETRIES times we
635 * will spread our requests in time to avoid stalling connection
636 * for too long
637 */
638 if (sta->ampdu_mlme.addba_req_num[tid] > HT_AGG_BURST_RETRIES &&
639 time_before(jiffies, sta->ampdu_mlme.last_addba_req_time[tid] +
640 HT_AGG_RETRIES_PERIOD)) {
bdcbd8e0 641 ht_dbg(sdata,
d81b0fd0 642 "BA request denied - %d failed requests on %pM tid %u\n",
0a214d3f 643 sta->ampdu_mlme.addba_req_num[tid], sta->sta.addr, tid);
84381b4e 644 ret = -EBUSY;
b8695a8f
JB
645 goto err_unlock_sta;
646 }
647
40b275b6 648 tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
b8695a8f 649 /* check if the TID is not in aggregation flow already */
ec034b20 650 if (tid_tx || sta->ampdu_mlme.tid_start_tx[tid]) {
bdcbd8e0 651 ht_dbg(sdata,
0a214d3f
JB
652 "BA request denied - session is not idle on %pM tid %u\n",
653 sta->sta.addr, tid);
b8695a8f
JB
654 ret = -EAGAIN;
655 goto err_unlock_sta;
656 }
657
658 /* prepare A-MPDU MLME for Tx aggregation */
a622ab72
JB
659 tid_tx = kzalloc(sizeof(struct tid_ampdu_tx), GFP_ATOMIC);
660 if (!tid_tx) {
b8695a8f 661 ret = -ENOMEM;
0ab33703 662 goto err_unlock_sta;
b8695a8f 663 }
96f5e66e 664
a622ab72 665 skb_queue_head_init(&tid_tx->pending);
0ab33703 666 __set_bit(HT_AGG_STATE_WANT_START, &tid_tx->state);
cd8ffc80 667
bd2ce6e4 668 tid_tx->timeout = timeout;
7cca2acd
KC
669 tid_tx->sta = sta;
670 tid_tx->tid = tid;
bd2ce6e4 671
285fa695 672 /* response timer */
7cca2acd 673 timer_setup(&tid_tx->addba_resp_timer, sta_addba_resp_timer_expired, 0);
b8695a8f 674
285fa695 675 /* tx timer */
7cca2acd
KC
676 timer_setup(&tid_tx->session_timer,
677 sta_tx_agg_session_timer_expired, TIMER_DEFERRABLE);
285fa695 678
0ab33703 679 /* assign a dialog token */
b8695a8f 680 sta->ampdu_mlme.dialog_token_allocator++;
a622ab72 681 tid_tx->dialog_token = sta->ampdu_mlme.dialog_token_allocator;
b8695a8f 682
ec034b20
JB
683 /*
684 * Finally, assign it to the start array; the work item will
685 * collect it and move it to the normal array.
686 */
687 sta->ampdu_mlme.tid_start_tx[tid] = tid_tx;
51a0d38d 688
0ab33703 689 ieee80211_queue_work(&local->hw, &sta->ampdu_mlme.work);
b8695a8f 690
0ab33703 691 /* this flow continues off the work */
96f5e66e 692 err_unlock_sta:
b8695a8f 693 spin_unlock_bh(&sta->lock);
b8695a8f
JB
694 return ret;
695}
696EXPORT_SYMBOL(ieee80211_start_tx_ba_session);
697
b1720231
JB
698static void ieee80211_agg_tx_operational(struct ieee80211_local *local,
699 struct sta_info *sta, u16 tid)
700{
40b275b6 701 struct tid_ampdu_tx *tid_tx;
50ea05ef
SS
702 struct ieee80211_ampdu_params params = {
703 .sta = &sta->sta,
704 .action = IEEE80211_AMPDU_TX_OPERATIONAL,
705 .tid = tid,
706 .timeout = 0,
707 .ssn = 0,
708 };
40b275b6 709
cfcdbde3 710 lockdep_assert_held(&sta->ampdu_mlme.mtx);
a622ab72 711
40b275b6 712 tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
50ea05ef
SS
713 params.buf_size = tid_tx->buf_size;
714 params.amsdu = tid_tx->amsdu;
40b275b6 715
0a214d3f
JB
716 ht_dbg(sta->sdata, "Aggregation is on for %pM tid %d\n",
717 sta->sta.addr, tid);
b1720231 718
50ea05ef 719 drv_ampdu_action(local, sta->sdata, &params);
cfcdbde3
JB
720
721 /*
722 * synchronize with TX path, while splicing the TX path
723 * should block so it won't put more packets onto pending.
724 */
725 spin_lock_bh(&sta->lock);
726
3a25a8c8 727 ieee80211_agg_splice_packets(sta->sdata, tid_tx, tid);
cd8ffc80 728 /*
a622ab72
JB
729 * Now mark as operational. This will be visible
730 * in the TX path, and lets it go lock-free in
731 * the common case.
cd8ffc80 732 */
40b275b6 733 set_bit(HT_AGG_STATE_OPERATIONAL, &tid_tx->state);
3a25a8c8 734 ieee80211_agg_splice_finish(sta->sdata, tid);
b1720231 735
cfcdbde3 736 spin_unlock_bh(&sta->lock);
ba8c3d6f
FF
737
738 ieee80211_agg_start_txq(sta, tid, true);
b1720231
JB
739}
740
7a7c0a64
JB
741void ieee80211_start_tx_ba_cb(struct sta_info *sta, int tid,
742 struct tid_ampdu_tx *tid_tx)
b8695a8f 743{
7a7c0a64 744 struct ieee80211_sub_if_data *sdata = sta->sdata;
c951ad35 745 struct ieee80211_local *local = sdata->local;
b8695a8f 746
7a7c0a64
JB
747 if (WARN_ON(test_and_set_bit(HT_AGG_STATE_DRV_READY, &tid_tx->state)))
748 return;
749
750 if (test_bit(HT_AGG_STATE_RESPONSE_RECEIVED, &tid_tx->state))
751 ieee80211_agg_tx_operational(local, sta, tid);
752}
753
754static struct tid_ampdu_tx *
755ieee80211_lookup_tid_tx(struct ieee80211_sub_if_data *sdata,
756 const u8 *ra, u16 tid, struct sta_info **sta)
757{
758 struct tid_ampdu_tx *tid_tx;
b5878a2d 759
5a306f58 760 if (tid >= IEEE80211_NUM_TIDS) {
bdcbd8e0 761 ht_dbg(sdata, "Bad TID value: tid = %d (>= %d)\n",
5a306f58 762 tid, IEEE80211_NUM_TIDS);
7a7c0a64 763 return NULL;
b8695a8f
JB
764 }
765
7a7c0a64
JB
766 *sta = sta_info_get_bss(sdata, ra);
767 if (!*sta) {
bdcbd8e0 768 ht_dbg(sdata, "Could not find station: %pM\n", ra);
7a7c0a64 769 return NULL;
b8695a8f
JB
770 }
771
7a7c0a64 772 tid_tx = rcu_dereference((*sta)->ampdu_mlme.tid_tx[tid]);
b8695a8f 773
7a7c0a64 774 if (WARN_ON(!tid_tx))
bdcbd8e0 775 ht_dbg(sdata, "addBA was not requested!\n");
96f5e66e 776
7a7c0a64 777 return tid_tx;
b8695a8f 778}
b8695a8f 779
c951ad35 780void ieee80211_start_tx_ba_cb_irqsafe(struct ieee80211_vif *vif,
86ab6c5a
JB
781 const u8 *ra, u16 tid)
782{
c951ad35
JB
783 struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif);
784 struct ieee80211_local *local = sdata->local;
7a7c0a64
JB
785 struct sta_info *sta;
786 struct tid_ampdu_tx *tid_tx;
86ab6c5a 787
7a7c0a64 788 trace_api_start_tx_ba_cb(sdata, ra, tid);
d15b8459 789
7a7c0a64
JB
790 rcu_read_lock();
791 tid_tx = ieee80211_lookup_tid_tx(sdata, ra, tid, &sta);
792 if (!tid_tx)
793 goto out;
86ab6c5a 794
7a7c0a64
JB
795 set_bit(HT_AGG_STATE_START_CB, &tid_tx->state);
796 ieee80211_queue_work(&local->hw, &sta->ampdu_mlme.work);
797 out:
798 rcu_read_unlock();
86ab6c5a
JB
799}
800EXPORT_SYMBOL(ieee80211_start_tx_ba_cb_irqsafe);
801
849b7967 802int __ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid,
c82c4a80 803 enum ieee80211_agg_stop_reason reason)
849b7967 804{
849b7967
JB
805 int ret;
806
cfcdbde3 807 mutex_lock(&sta->ampdu_mlme.mtx);
849b7967 808
c82c4a80 809 ret = ___ieee80211_stop_tx_ba_session(sta, tid, reason);
849b7967 810
cfcdbde3
JB
811 mutex_unlock(&sta->ampdu_mlme.mtx);
812
849b7967
JB
813 return ret;
814}
b8695a8f 815
6a8579d0 816int ieee80211_stop_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid)
b8695a8f 817{
c951ad35
JB
818 struct sta_info *sta = container_of(pubsta, struct sta_info, sta);
819 struct ieee80211_sub_if_data *sdata = sta->sdata;
820 struct ieee80211_local *local = sdata->local;
0ab33703
JB
821 struct tid_ampdu_tx *tid_tx;
822 int ret = 0;
b8695a8f 823
6a8579d0 824 trace_api_stop_tx_ba_session(pubsta, tid);
b5878a2d 825
4253119a 826 if (!local->ops->ampdu_action)
23e6a7ea
JB
827 return -EINVAL;
828
5a306f58 829 if (tid >= IEEE80211_NUM_TIDS)
b8695a8f
JB
830 return -EINVAL;
831
0ab33703 832 spin_lock_bh(&sta->lock);
40b275b6 833 tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
0ab33703
JB
834
835 if (!tid_tx) {
836 ret = -ENOENT;
837 goto unlock;
838 }
839
b6da911b
LK
840 WARN(sta->reserved_tid == tid,
841 "Requested to stop BA session on reserved tid=%d", tid);
842
0ab33703
JB
843 if (test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) {
844 /* already in progress stopping it */
845 ret = 0;
846 goto unlock;
847 }
848
849 set_bit(HT_AGG_STATE_WANT_STOP, &tid_tx->state);
850 ieee80211_queue_work(&local->hw, &sta->ampdu_mlme.work);
851
852 unlock:
853 spin_unlock_bh(&sta->lock);
854 return ret;
b8695a8f
JB
855}
856EXPORT_SYMBOL(ieee80211_stop_tx_ba_session);
857
7a7c0a64
JB
858void ieee80211_stop_tx_ba_cb(struct sta_info *sta, int tid,
859 struct tid_ampdu_tx *tid_tx)
b8695a8f 860{
7a7c0a64 861 struct ieee80211_sub_if_data *sdata = sta->sdata;
2c158887 862 bool send_delba = false;
b8695a8f 863
7a7c0a64
JB
864 ht_dbg(sdata, "Stopping Tx BA session for %pM tid %d\n",
865 sta->sta.addr, tid);
b8695a8f 866
a622ab72 867 spin_lock_bh(&sta->lock);
a622ab72 868
7a7c0a64 869 if (!test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) {
0a214d3f
JB
870 ht_dbg(sdata,
871 "unexpected callback to A-MPDU stop for %pM tid %d\n",
872 sta->sta.addr, tid);
cfcdbde3 873 goto unlock_sta;
b8695a8f
JB
874 }
875
53f73c09 876 if (tid_tx->stop_initiator == WLAN_BACK_INITIATOR && tid_tx->tx_stop)
2c158887 877 send_delba = true;
b8695a8f 878
faec12ee 879 ieee80211_remove_tid_tx(sta, tid);
b8695a8f 880
cfcdbde3 881 unlock_sta:
a622ab72 882 spin_unlock_bh(&sta->lock);
2c158887
JB
883
884 if (send_delba)
7a7c0a64 885 ieee80211_send_delba(sdata, sta->sta.addr, tid,
2c158887 886 WLAN_BACK_INITIATOR, WLAN_REASON_QSTA_NOT_USE);
b8695a8f 887}
b8695a8f 888
c951ad35 889void ieee80211_stop_tx_ba_cb_irqsafe(struct ieee80211_vif *vif,
b8695a8f
JB
890 const u8 *ra, u16 tid)
891{
c951ad35
JB
892 struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif);
893 struct ieee80211_local *local = sdata->local;
7a7c0a64
JB
894 struct sta_info *sta;
895 struct tid_ampdu_tx *tid_tx;
b8695a8f 896
7a7c0a64 897 trace_api_stop_tx_ba_cb(sdata, ra, tid);
d15b8459 898
7a7c0a64
JB
899 rcu_read_lock();
900 tid_tx = ieee80211_lookup_tid_tx(sdata, ra, tid, &sta);
901 if (!tid_tx)
902 goto out;
b8695a8f 903
7a7c0a64
JB
904 set_bit(HT_AGG_STATE_STOP_CB, &tid_tx->state);
905 ieee80211_queue_work(&local->hw, &sta->ampdu_mlme.work);
906 out:
907 rcu_read_unlock();
b8695a8f
JB
908}
909EXPORT_SYMBOL(ieee80211_stop_tx_ba_cb_irqsafe);
910
86ab6c5a 911
b8695a8f
JB
912void ieee80211_process_addba_resp(struct ieee80211_local *local,
913 struct sta_info *sta,
914 struct ieee80211_mgmt *mgmt,
915 size_t len)
916{
a622ab72 917 struct tid_ampdu_tx *tid_tx;
6e0456b5 918 struct ieee80211_txq *txq;
41cbb0f5 919 u16 capab, tid, buf_size;
e3abc8ff 920 bool amsdu;
b8695a8f
JB
921
922 capab = le16_to_cpu(mgmt->u.action.u.addba_resp.capab);
e3abc8ff 923 amsdu = capab & IEEE80211_ADDBA_PARAM_AMSDU_MASK;
b8695a8f 924 tid = (capab & IEEE80211_ADDBA_PARAM_TID_MASK) >> 2;
0b01f030 925 buf_size = (capab & IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK) >> 6;
ac062197 926 buf_size = min(buf_size, local->hw.max_tx_aggregation_subframes);
b8695a8f 927
6e0456b5
FF
928 txq = sta->sta.txq[tid];
929 if (!amsdu && txq)
930 set_bit(IEEE80211_TXQ_NO_AMSDU, &to_txq_info(txq)->flags);
931
cfcdbde3 932 mutex_lock(&sta->ampdu_mlme.mtx);
b8695a8f 933
40b275b6 934 tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
a622ab72 935 if (!tid_tx)
8ade0082 936 goto out;
b8695a8f 937
a622ab72 938 if (mgmt->u.action.u.addba_resp.dialog_token != tid_tx->dialog_token) {
0a214d3f
JB
939 ht_dbg(sta->sdata, "wrong addBA response token, %pM tid %d\n",
940 sta->sta.addr, tid);
8ade0082 941 goto out;
b8695a8f
JB
942 }
943
d305a655 944 del_timer_sync(&tid_tx->addba_resp_timer);
8ade0082 945
0a214d3f
JB
946 ht_dbg(sta->sdata, "switched off addBA timer for %pM tid %d\n",
947 sta->sta.addr, tid);
d305a655
NM
948
949 /*
950 * addba_resp_timer may have fired before we got here, and
951 * caused WANT_STOP to be set. If the stop then was already
952 * processed further, STOPPING might be set.
953 */
954 if (test_bit(HT_AGG_STATE_WANT_STOP, &tid_tx->state) ||
955 test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) {
bdcbd8e0 956 ht_dbg(sta->sdata,
0a214d3f
JB
957 "got addBA resp for %pM tid %d but we already gave up\n",
958 sta->sta.addr, tid);
d305a655
NM
959 goto out;
960 }
961
3ca97880
HS
962 /*
963 * IEEE 802.11-2007 7.3.1.14:
964 * In an ADDBA Response frame, when the Status Code field
965 * is set to 0, the Buffer Size subfield is set to a value
966 * of at least 1.
967 */
b8695a8f 968 if (le16_to_cpu(mgmt->u.action.u.addba_resp.status)
3ca97880 969 == WLAN_STATUS_SUCCESS && buf_size) {
a622ab72
JB
970 if (test_and_set_bit(HT_AGG_STATE_RESPONSE_RECEIVED,
971 &tid_tx->state)) {
972 /* ignore duplicate response */
973 goto out;
974 }
b8695a8f 975
0b01f030 976 tid_tx->buf_size = buf_size;
e3abc8ff 977 tid_tx->amsdu = amsdu;
0b01f030 978
a622ab72 979 if (test_bit(HT_AGG_STATE_DRV_READY, &tid_tx->state))
b1720231 980 ieee80211_agg_tx_operational(local, sta, tid);
b8695a8f 981
b1720231 982 sta->ampdu_mlme.addba_req_num[tid] = 0;
285fa695 983
914eac24
SS
984 tid_tx->timeout =
985 le16_to_cpu(mgmt->u.action.u.addba_resp.timeout);
986
12d3952f 987 if (tid_tx->timeout) {
285fa695
NM
988 mod_timer(&tid_tx->session_timer,
989 TU_TO_EXP_TIME(tid_tx->timeout));
12d3952f
FF
990 tid_tx->last_tx = jiffies;
991 }
285fa695 992
b8695a8f 993 } else {
c82c4a80 994 ___ieee80211_stop_tx_ba_session(sta, tid, AGG_STOP_DECLINED);
b8695a8f 995 }
2171abc5 996
2171abc5 997 out:
cfcdbde3 998 mutex_unlock(&sta->ampdu_mlme.mtx);
b8695a8f 999}
This page took 0.713352 seconds and 4 git commands to generate.