]> Git Repo - buildroot-mgba.git/commit - Makefile
Makefile: fix issue with printvars executing giant shell command
authorTrent Piepho <[email protected]>
Mon, 17 Sep 2018 18:10:54 +0000 (11:10 -0700)
committerThomas Petazzoni <[email protected]>
Tue, 18 Sep 2018 20:03:23 +0000 (22:03 +0200)
commitb8d0aadc6d52733cfc914ba3cd6f506238bd19f7
tree52cd815256c6a7f550049144248f785f59d15073
parentca5ae83ccb7237e00d47cb4251ad2735012ae786
Makefile: fix issue with printvars executing giant shell command

The underlying problem is that $(foreach V,1 2 3,) does not evaluate to
an empty string.  It evaluates to "  ", three empty strings separated by
whitespace.

A construct of this format, with a giant list in the foreach, is part of
the printvars command.  This means that "@:$(foreach ....)", which is
intended to expand to a null command, in fact expands to "@:       "
with a great deal of whitespace.  Make chooses to execute this command
with:
    execve("/bin/sh", ["/bin/sh", "-c", ":       "]

But with far more whitespace.  So much that it can exceed shell command
line length limits.

This solution is to move the foreach to another step in the recipe.  The
"@:" is retained as the first line so the recipe is not Empty, which
would cause a change in make behavior when make builds the target.  The
2nd line, all whitespace, will be skipped by make.

Signed-off-by: Trent Piepho <[email protected]>
Tested-by: "Yann E. MORIN" <[email protected]>
Acked-by: "Yann E. MORIN" <[email protected]>
Signed-off-by: Thomas Petazzoni <[email protected]>
Makefile
This page took 0.031443 seconds and 4 git commands to generate.