From: Tom Tromey <tom@tromey.com>
Date: Tue, 1 Oct 2019 23:42:17 +0000 (-0600)
Subject: Don't call erase_data_content from tui_data_window::show_registers
X-Git-Url: https://repo.jachan.dev/binutils.git/commitdiff_plain/a31bff9d2d78d0d45e3e75dd2513ccbf480a7bc4

Don't call erase_data_content from tui_data_window::show_registers

tui_data_window::show_registers currently calls erase_data_content.
However, I think it's better to have fewer calls to this (ideally just
one would suffice).  This refactors that function to remove this call.

gdb/ChangeLog
2019-10-09  Tom Tromey  <tom@tromey.com>

	* tui/tui-regs.c (tui_data_window::show_registers): Don't call
	erase_data_content.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bca7b7b4ff..a5504a9c00 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-09  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui-regs.c (tui_data_window::show_registers): Don't call
+	erase_data_content.
+
 2019-10-09  Tom Tromey  <tom@tromey.com>
 
 	* tui/tui-wingeneral.h (tui_delete_win): Don't declare.
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 474b62e204..1d936f712b 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -154,13 +154,14 @@ tui_data_window::show_registers (struct reggroup *group)
       for (auto &&data_item_win : m_regs_content)
 	data_item_win.highlight = false;
       m_current_group = group;
-      rerender ();
     }
   else
     {
       m_current_group = 0;
-      erase_data_content (_("[ Register Values Unavailable ]"));
+      m_regs_content.clear ();
     }
+
+  rerender ();
 }