From: Nick Alcock <nick.alcock@oracle.com>
Date: Fri, 20 Nov 2020 13:34:04 +0000 (+0000)
Subject: libctf, include: add ctf_getsymsect and ctf_getstrsect
X-Git-Url: https://repo.jachan.dev/binutils.git/commitdiff_plain/97a2a623d0193dbfc92d92545b63aaffd6099272

libctf, include: add ctf_getsymsect and ctf_getstrsect

libctf has long provided ctf_getdatasect, which hands back a pointer to
the CTF section a (read-only) dict came from.  But it has no such
functions to return pointers to the ELF symbol table or string table
it's working from, which is unfortunate because several libctf functions
(ctf_open, ctf_fdopen, and ctf_bfdopen) figure out which string and
symbol table to use themselves, and don't tell the user what they
decided, so the caller can't agree on which symtab to use with libctf
even if it wanted to.

Add a pair of functions to return the symtab and strtab in use.  Like
ctf_getdatasect, these return ctf_sect_t structures by value, filled
with all-NULL/0 content if a symtab or strtab is not being used.

include/ChangeLog
2020-11-20  Nick Alcock  <nick.alcock@oracle.com>

	* ctf-api.h (ctf_getsymsect): New.
	(ctf_getstrsect): Likewise.

libctf/ChangeLog
2020-11-20  Nick Alcock  <nick.alcock@oracle.com>

	* ctf-open.c (ctf_getsymsect): New.
	(ctf_getstrsect): Likewise.
	* libctf.ver: Add them.
---

diff --git a/include/ChangeLog b/include/ChangeLog
index 1d4eac95ad..704c9af3ba 100644
--- a/include/ChangeLog
+++ b/include/ChangeLog
@@ -1,3 +1,8 @@
+2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
+
+	* ctf-api.h (ctf_getsymsect): New.
+	(ctf_getstrsect): Likewise.
+
 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
 
 	* ctf-api.h (ctf_arc_lookup_symbol): New.
diff --git a/include/ctf-api.h b/include/ctf-api.h
index f0c00c01a8..8687475cc6 100644
--- a/include/ctf-api.h
+++ b/include/ctf-api.h
@@ -307,6 +307,8 @@ extern ctf_archive_t *ctf_open (const char *filename,
 				const char *target, int *errp);
 extern void ctf_close (ctf_archive_t *);
 extern ctf_sect_t ctf_getdatasect (const ctf_dict_t *);
+extern ctf_sect_t ctf_getsymsect (const ctf_dict_t *);
+extern ctf_sect_t ctf_getstrsect (const ctf_dict_t *);
 extern ctf_archive_t *ctf_get_arc (const ctf_dict_t *);
 extern ctf_archive_t *ctf_arc_open (const char *, int *);
 extern ctf_archive_t *ctf_arc_bufopen (const ctf_sect_t *,
diff --git a/libctf/ChangeLog b/libctf/ChangeLog
index deca027786..685c06a014 100644
--- a/libctf/ChangeLog
+++ b/libctf/ChangeLog
@@ -1,3 +1,9 @@
+2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
+
+	* ctf-open.c (ctf_getsymsect): New.
+	(ctf_getstrsect): Likewise.
+	* libctf.ver: Add them.
+
 2020-11-20  Nick Alcock  <nick.alcock@oracle.com>
 
 	* ctf-impl.h (struct ctf_archive_internal) <ctfi_dicts>: New, dicts
diff --git a/libctf/ctf-open.c b/libctf/ctf-open.c
index 3281c678ac..ecf27eeeb2 100644
--- a/libctf/ctf-open.c
+++ b/libctf/ctf-open.c
@@ -1854,6 +1854,18 @@ ctf_getdatasect (const ctf_dict_t *fp)
   return fp->ctf_data;
 }
 
+ctf_sect_t
+ctf_getsymsect (const ctf_dict_t *fp)
+{
+  return fp->ctf_symtab;
+}
+
+ctf_sect_t
+ctf_getstrsect (const ctf_dict_t *fp)
+{
+  return fp->ctf_strtab;
+}
+
 /* Return the CTF handle for the parent CTF dict, if one exists.  Otherwise
    return NULL to indicate this dict has no imported parent.  */
 ctf_dict_t *
diff --git a/libctf/libctf.ver b/libctf/libctf.ver
index f0633f26c4..cfecc89435 100644
--- a/libctf/libctf.ver
+++ b/libctf/libctf.ver
@@ -190,4 +190,7 @@ LIBCTF_1.1 {
 
 	ctf_arc_lookup_symbol;
 	ctf_arc_flush_caches;
+
+	ctf_getsymsect;
+	ctf_getstrsect;
 } LIBCTF_1.0;