From: H.J. Lu <hjl.tools@gmail.com>
Date: Wed, 30 Sep 2020 12:23:20 +0000 (-0700)
Subject: ld: Override the IR definition for non-ELF targets
X-Git-Url: https://repo.jachan.dev/binutils.git/commitdiff_plain/04e433a8571e727108b8f1b9a04ba5c7ab20112c

ld: Override the IR definition for non-ELF targets

For non-ELF targets, override the IR definition before all LTO symbols
have been read.

	PR ld/26675
	* plugin.c (plugin_notice): Override the IR definition before
	all LTO symbols have been read for non-ELF targets.
---

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 369252761c..134db8cdac 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,9 @@
+2020-09-30  H.J. Lu  <hongjiu.lu@intel.com>
+
+	PR ld/26675
+	* plugin.c (plugin_notice): Override the IR definition before
+	all LTO symbols have been read for non-ELF targets.
+
 2020-09-30  Jeremy Drake  <sourceware-bugzilla@jdrake.com>
 
 	PR 26588
diff --git a/ld/plugin.c b/ld/plugin.c
index 5640b8975b..067551c476 100644
--- a/ld/plugin.c
+++ b/ld/plugin.c
@@ -1436,8 +1436,10 @@ plugin_notice (struct bfd_link_info *info,
 	 this by making the symbol appear to be undefined.
 
 	 NB: We change the previous definition in the IR object to
-	 undefweak only after all LTO symbols have been read.  */
-      else if (info->lto_all_symbols_read
+	 undefweak only after all LTO symbols have been read or for
+	 non-ELF targets.  */
+      else if ((info->lto_all_symbols_read
+		|| bfd_get_flavour (abfd) != bfd_target_elf_flavour)
 	       && (((h->type == bfd_link_hash_defweak
 		     || h->type == bfd_link_hash_defined)
 		    && is_ir_dummy_bfd (sym_bfd = h->u.def.section->owner))