Simon [Fri, 10 Mar 2017 18:01:48 +0000 (10:01 -0800)]
Remove QT translation support files
Daira Hopwood [Fri, 10 Mar 2017 03:49:04 +0000 (03:49 +0000)]
Delete -rootcertificates from bash completion script.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Simon [Fri, 10 Mar 2017 01:04:59 +0000 (17:04 -0800)]
Remove stale Qt comments and dead code
Daira Hopwood [Tue, 7 Mar 2017 19:40:09 +0000 (19:40 +0000)]
Remove unused packages and patches.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 4 Mar 2017 22:58:54 +0000 (22:58 +0000)]
.gitignore cache/ and venv-mnf/
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 4 Mar 2017 06:02:29 +0000 (06:02 +0000)]
Remove NO_QT make option.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 4 Mar 2017 05:51:32 +0000 (05:51 +0000)]
Update which libraries are allowed to be linked to zcashd by symbol-check.py.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 4 Mar 2017 05:50:02 +0000 (05:50 +0000)]
Update documentation for QT removal.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Sat, 4 Mar 2017 05:49:30 +0000 (05:49 +0000)]
Remove some more QT-related stragglers.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Fri, 10 Feb 2017 01:56:21 +0000 (01:56 +0000)]
Remove QT gunk from Makefiles.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 7 Feb 2017 00:19:29 +0000 (00:19 +0000)]
Correct license text for LGPL.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 7 Mar 2017 19:14:59 +0000 (19:14 +0000)]
License updates for removal of src/qt.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Daira Hopwood [Tue, 25 Oct 2016 05:07:27 +0000 (06:07 +0100)]
Remove src/qt.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
zkbot [Sat, 4 Mar 2017 02:57:46 +0000 (02:57 +0000)]
Auto merge of #2100 - str4d:2074-rpc, r=arcalinea
Bitcoin 0.12 RPC PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6266
- bitcoin/bitcoin#6257
- bitcoin/bitcoin#6271
- bitcoin/bitcoin#6158
- bitcoin/bitcoin#6307
- bitcoin/bitcoin#6290
- bitcoin/bitcoin#6262
- bitcoin/bitcoin#6088
- bitcoin/bitcoin#6339
- bitcoin/bitcoin#6299 (partial, remainder in #2099)
- bitcoin/bitcoin#6350
- bitcoin/bitcoin#6247
- bitcoin/bitcoin#6362
- bitcoin/bitcoin#5486
- bitcoin/bitcoin#6417
- bitcoin/bitcoin#6398 (partial, remainder was included in #1950)
- bitcoin/bitcoin#6444
- bitcoin/bitcoin#6456 (partial, remainder was included in #2082)
- bitcoin/bitcoin#6380
- bitcoin/bitcoin#6970
Part of #2074.
zkbot [Fri, 3 Mar 2017 21:25:03 +0000 (21:25 +0000)]
Auto merge of #2101 - str4d:2074-tests, r=arcalinea
Bitcoin 0.12 test PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6337
- bitcoin/bitcoin#6390
- bitcoin/bitcoin#5515
- bitcoin/bitcoin#6287 (partial, remainder included in bitcoin/bitcoin#6703)
- bitcoin/bitcoin#6465
Part of #2074.
zkbot [Fri, 3 Mar 2017 20:41:57 +0000 (20:41 +0000)]
Auto merge of #2099 - str4d:2074-misc, r=arcalinea
Bitcoin 0.12 misc PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6198
- bitcoin/bitcoin#6206
- bitcoin/bitcoin#5927
- bitcoin/bitcoin#6213
- bitcoin/bitcoin#6061
- bitcoin/bitcoin#6283 (partial, remainder was pulled in #929)
- bitcoin/bitcoin#6272
- bitcoin/bitcoin#6316
- bitcoin/bitcoin#6133
- bitcoin/bitcoin#6387
- bitcoin/bitcoin#6401
- bitcoin/bitcoin#6434
- bitcoin/bitcoin#6372
- bitcoin/bitcoin#6447
- bitcoin/bitcoin#6149
- bitcoin/bitcoin#6468
Part of #2074.
Casey Rodarmor [Wed, 22 Jul 2015 16:03:16 +0000 (12:03 -0400)]
Don't share objects between TestInstances
Cory Fields [Tue, 16 Jun 2015 08:08:26 +0000 (04:08 -0400)]
locking: add a quick example of GUARDED_BY
This was chosen not because it's necessarily helpful, but because its locking
assumptions were already correct.
Cory Fields [Tue, 16 Jun 2015 07:46:36 +0000 (03:46 -0400)]
locking: teach Clang's -Wthread-safety to cope with our scoped lock macros
This allows us to use function/variable/class attributes to specify locking
requisites, allowing problems to be detected during static analysis.
This works perfectly with newer Clang versions (tested with 3.3-3.7). For older
versions (tested 3.2), it compiles fine but spews lots of false-positives.
Matt Corallo [Sat, 20 Dec 2014 10:35:33 +0000 (05:35 -0500)]
Assert on probable deadlocks if the second lock isnt try_lock
Wladimir J. van der Laan [Tue, 7 Jul 2015 16:18:14 +0000 (18:18 +0200)]
tests: Fix bitcoin-tx signing testcase
Fixes wrong scriptPubkey problem, which caused the transaction to
not actually be signed.
Gavin Andresen [Fri, 19 Jun 2015 14:42:39 +0000 (10:42 -0400)]
Testing infrastructure: mocktime fixes
New, undocumented-on-purpose -mocktime=timestamp command-line
argument to startup with mocktime set. Needed because
time-related blockchain sanity checks are done on startup, before a
test has a chance to make a setmocktime RPC call.
And changed the setmocktime RPC call so calling it will not result in
currently connected peers being disconnected due to inactivity timeouts.
Jonas Schnelli [Thu, 23 Jul 2015 19:05:00 +0000 (21:05 +0200)]
don't try to decode invalid encoded ext keys
Jonas Schnelli [Thu, 23 Jul 2015 14:22:37 +0000 (16:22 +0200)]
extend bip32 tests to cover Base58c/CExtKey decode
Jonas Schnelli [Thu, 23 Jul 2015 14:14:17 +0000 (16:14 +0200)]
fix and extend CBitcoinExtKeyBase template
- fix Decode call (req. only one param)
- add constructor for base58c->CExtKey
Adam Weiss [Fri, 15 May 2015 19:31:14 +0000 (15:31 -0400)]
Buffer log messages and explicitly open logs
Prevents stomping on debug logs in datadirs that are locked by other
instances and lost parameter interaction messages that can get wiped by
ShrinkDebugFile().
The log is now opened explicitly and all emitted messages are buffered
until this open occurs. The version message and log cut have also been
moved to the earliest possible sensible location.
Pavel Vasin [Tue, 30 Jun 2015 20:10:27 +0000 (23:10 +0300)]
remove unused inv from ConnectTip()
Paul Georgiou [Fri, 10 Jul 2015 16:21:21 +0000 (19:21 +0300)]
Update Linearize tool to support Windows paths
Gavin Andresen [Mon, 13 Jul 2015 18:28:03 +0000 (14:28 -0400)]
configure --enable-debug changes
Three changes to how configure --enable-debug behaves:
1. Preserve user-passed CXXFLAGS/CFLAGS
2. Compile with -DDEBUG_LOCKORDER
3. Add -DDEBUG -DDEBUG_LOCKORDER to CPPFLAGS (since they are preprocessor options)
Florian Schmaus [Wed, 8 Jul 2015 20:35:29 +0000 (22:35 +0200)]
Add BITCOIND_SIGTERM_TIMEOUT to OpenRC init scripts
This allows users to specify, e.g. raise, the default timeout of 60
seconds. Some bitcoind instances, especially long running ones on slow
hardware, require a higher timeout for a clean shut down.
Also add a comment to bitcoind.openrc's 'retry=', since it is not
obvious from the variable name what it does.
Jonas Schnelli [Tue, 7 Jul 2015 10:15:44 +0000 (12:15 +0200)]
[bitcoin-cli] improve error output
Luke Dashjr [Wed, 13 May 2015 20:04:39 +0000 (20:04 +0000)]
Fix various warnings
Found while building on Debian 7
Wladimir J. van der Laan [Sun, 21 Jun 2015 06:22:31 +0000 (08:22 +0200)]
build: Remove -DBOOST_SPIRIT_THREADSAFE
Now that boost spirit is no longer used, `-DBOOST_SPIRIT_THREADSAFE`
doesn't need to be passed to the compiler anymore.
Wladimir J. van der Laan [Mon, 15 Jun 2015 10:44:56 +0000 (12:44 +0200)]
tests: Extend RPC proxy tests
Also test -noonion
Wladimir J. van der Laan [Wed, 10 Jun 2015 07:19:13 +0000 (09:19 +0200)]
Improve proxy initialization
Simplify and make the code in AppInit2 more clear.
This provides a straightforward flow, gets rid of .count() (which makes
it possible to override an earlier provided proxy option to nothing), as
well as comments the different cases.
Philip Kaufmann [Mon, 15 Jun 2015 12:43:31 +0000 (14:43 +0200)]
make CAddrMan::size() return the correct type of size_t
Jorge Timón [Fri, 24 Apr 2015 14:45:16 +0000 (16:45 +0200)]
Consensus: Refactor: Separate Consensus::CheckTxInputs and GetSpendHeight in CheckInputs
Zcash:
- Replaces some of the refactoring performed in #1017
- Exposed Consensus::CheckTxInputs for testing
Philip Kaufmann [Mon, 1 Jun 2015 12:37:21 +0000 (14:37 +0200)]
[init] add -blockversion help and extend -upnp help
Pieter Wuille [Thu, 19 Mar 2015 12:34:06 +0000 (05:34 -0700)]
Reduce checkpoints' effect on consensus.
Instead of only checking height to decide whether to disable script checks,
actually check whether a block is an ancestor of a checkpoint, up to which
headers have been validated. This means that we don't have to prevent
accepting a side branch anymore - it will be safe, just less fast to
do.
We still need to prevent being fed a multitude of low-difficulty headers
filling up our memory. The mechanism for that is unchanged for now: once
a checkpoint is reached with headers, no headers chain branching off before
that point are allowed anymore.
Philip Kaufmann [Sun, 31 May 2015 13:36:44 +0000 (15:36 +0200)]
use const references where appropriate
Peter Todd [Thu, 28 May 2015 01:02:04 +0000 (21:02 -0400)]
Improve comment explaining purpose of MAX_MONEY constant
Jack Grigg [Tue, 28 Feb 2017 19:52:34 +0000 (11:52 -0800)]
Fix typo in listbanned RPC keys
Jack Grigg [Tue, 28 Feb 2017 19:51:46 +0000 (11:51 -0800)]
Update default RPC port in help strings
Jack Grigg [Tue, 28 Feb 2017 19:50:36 +0000 (11:50 -0800)]
BTC -> ZEC in paytxfee RPC docs
Revert before merging bitcoin/bitcoin#6504.
Jack Grigg [Tue, 28 Feb 2017 20:49:22 +0000 (12:49 -0800)]
Re-encode t-addrs in disablewallet.py with Zcash prefixes
Jack Grigg [Wed, 15 Feb 2017 16:12:06 +0000 (16:12 +0000)]
Adjust fundrawtransaction RPC test for Zcash
- Enable wallet encryption
- Correct block reward
Wladimir J. van der Laan [Mon, 9 Nov 2015 07:40:46 +0000 (08:40 +0100)]
Fix crash in validateaddress with -disablewallet
Fix a null pointer dereference in validateaddress with -disablewallet. Also add a regression testcase.
Jonas Schnelli [Tue, 14 Jul 2015 19:13:16 +0000 (21:13 +0200)]
[QA] add testcases for parsing strings as values
Wladimir J. van der Laan [Mon, 6 Jul 2015 09:43:56 +0000 (11:43 +0200)]
rpc: Accept strings in AmountFromValue
Accept strings containing decimal values, in addition to bare values.
Useful from JSON-RPC implementations where it's not possible to have
direct control over the text of numbers (e.g. where numbers are always
doubles), and it's still desired to send an exact value.
This would allow users to post JSON content with numbers encoded like
`{"value": "0.
00000001"}` instead of `{"value": 0.
00000001}` which some
php/python encoders wrap into 1e-8, or worse.
Wladimir J. van der Laan [Sat, 18 Jul 2015 05:44:19 +0000 (07:44 +0200)]
univalue: Avoid unnecessary roundtrip through double for numbers
JSON makes no distinction between numbers and reals, and our code
doesn't need to do so either.
This removes VREAL, as well as its specific post-processing in
`UniValue::write`. Non-monetary amounts do not need to be forcibly
formatted with 8 decimals, so the extra roundtrip was unnecessary
(and potentially loses precision).
Zcash: cherry-picked from commit
7650449a6777710cf818d41862626164da0cd412
Left over from
2aee4619304adb9cecf4a9a4b04d83e0fc4d9d8d
zathras-crypto [Wed, 25 Mar 2015 09:04:02 +0000 (02:04 -0700)]
Exempt unspendable transaction outputs from dust checks
Since unspendable outputs can't be spent, there is no threshold at which it would be uneconomic to spend them.
This primarily targets transaction outputs with `OP_RETURN`.
---
Initially based on:
commit
9cf0ae26350033d43d5dd3c95054c0d1b1641eda
Author: zathras-crypto <zathrasc@gmail.com>
Date: Wed Mar 25 02:04:02 2015 -0700
Changes:
- cherry-picked on top of bitcoin:master
- added RPC test for fundrawtransaction
Wladimir J. van der Laan [Wed, 8 Jul 2015 12:47:39 +0000 (14:47 +0200)]
rpc: Remove chain-specific RequireRPCPassword
I've never liked the chain-specific exception to having to set a
password. It gives issues with #6388 which makes it valid to
set no password in every case (as it enables random cookie authentication).
This pull removes the flag, so that all chains are regarded the same.
It also removes the username==password test, which doesn't provide any
substantial extra security.
Jonas Schnelli [Fri, 10 Jul 2015 19:14:33 +0000 (21:14 +0200)]
[QA] remove rawtransactions.py from the extended test list
rawtransactions.py is already in the standard test list
Jonas Schnelli [Fri, 10 Jul 2015 18:11:44 +0000 (20:11 +0200)]
[QA] fix possible reorg issue in rawtransaction.py/fundrawtransaction.py RPC test
- added missing mempool sync between block generations
Jonas Schnelli [Tue, 16 Dec 2014 09:50:44 +0000 (10:50 +0100)]
[REST] add JSON support for /rest/headers/
Forrest Voight [Thu, 2 Jul 2015 01:34:31 +0000 (21:34 -0400)]
When processing RPC commands during warmup phase, parse the
request object before returning an error so that id value can
be used in the response.
Prior to this commit, RPC commands sent during Bitcoin's
warmup/startup phase were responded to with a JSON-RPC error
with an id of null, which violated the JSON-RPC 2.0 spec:
id: This member is REQUIRED. It MUST be the same as the value
of the id member in the Request Object. If there was an error
in detecting the id in the Request object (e.g. Parse
error/Invalid Request), it MUST be Null.
Jack Grigg [Wed, 15 Feb 2017 14:54:58 +0000 (14:54 +0000)]
Adjust blockheaderToJSON() for Zcash block header
Peter Todd [Fri, 5 Jun 2015 19:37:17 +0000 (17:07 -0230)]
Add getblockheader RPC call
Alternative to getblock that works even when the block itself has been
pruned, returning all available information.
mruddy [Tue, 30 Jun 2015 13:40:44 +0000 (09:40 -0400)]
add tests for the decodescript rpc. add mention of the rpc regression tests to the testing seciton of the main readme.
Wladimir J. van der Laan [Wed, 17 Jun 2015 16:06:39 +0000 (18:06 +0200)]
test: Move reindex test to standard tests
This test finishes very quickly, so it should be part of the default set
of tests in rpc-tests.
Jonas Schnelli [Wed, 24 Jun 2015 20:31:10 +0000 (22:31 +0200)]
UniValue: don't escape solidus, keep espacing of reverse solidus
Zcash: The UniValue changes are already merged; this updates the test
Jonas Schnelli [Sat, 25 Apr 2015 01:26:30 +0000 (18:26 -0700)]
fundrawtransaction tests
Matt Corallo [Sat, 25 Apr 2015 01:27:30 +0000 (18:27 -0700)]
Add fundrawtransaction RPC method
Matt Corallo [Sat, 25 Apr 2015 01:29:00 +0000 (18:29 -0700)]
Add FundTransaction method to wallet
Some code stolen from Jonas Schnelli <jonas.schnelli@include7.ch>
Matt Corallo [Sat, 25 Apr 2015 01:27:00 +0000 (18:27 -0700)]
Small tweaks to CCoinControl for fundrawtransaction
Pieter Wuille [Fri, 1 May 2015 13:21:06 +0000 (15:21 +0200)]
Add DummySignatureCreator which just creates zeroed sigs
dexX7 [Tue, 9 Jun 2015 15:11:13 +0000 (17:11 +0200)]
Return all available information via validateaddress
`"validateaddress"` omits some information, even in cases where is it available.
The primary motivation is to be able to retrieve redeemScripts, after using `"addmultisigaddress"`, when not all keys are available in the keystore, but the redeemScript actually is.
The output of `"validateaddress"` with this commit:
Keys not available:
```js
validateaddress "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3"
{
"isvalid": true,
"address": "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
"scriptPubKey": "
76a914fa20d564550b105787f7ce3a9ad7fd9a45cd407088ac",
"ismine": false,
"iswatchonly": false,
"isscript": false
}
```
```js
validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
"isvalid": true,
"address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
"scriptPubKey": "
a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
"ismine": false,
"iswatchonly": false,
"isscript": true
}
```
After adding the redeemScript:
```js
addmultisigaddress 2 '["02537357B156A33306A7A014A3748631C59DF405B56F11BA4AA4A3CE81501AF095","02F1FB200390E7864EF4450C07B15988179A57C3CF3A878F668E1070CB615749FE"]'
2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK
validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
"isvalid": true,
"address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
"scriptPubKey": "
a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
"ismine": false,
"iswatchonly": false,
"isscript": true,
"script": "multisig",
"hex": "522102537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af0952102f1fb200390e7864ef4450c07b15988179a57c3cf3a878f668e1070cb615749fe52ae",
"addresses": [
"n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
"mmSKNtbYYHRrhTLKiok5TuYrGEs4Y2A4k6"
],
"sigsrequired": 2,
"account": ""
}
```
All keys available:
```js
validateaddress "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3"
{
"isvalid": true,
"address": "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
"scriptPubKey": "
76a914fa20d564550b105787f7ce3a9ad7fd9a45cd407088ac",
"ismine": true,
"iswatchonly": false,
"isscript": false,
"pubkey": "02537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af095",
"iscompressed": true,
"account": ""
}
```
```js
validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
"isvalid": true,
"address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
"scriptPubKey": "
a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
"ismine": true,
"iswatchonly": false,
"isscript": true,
"script": "multisig",
"hex": "522102537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af0952102f1fb200390e7864ef4450c07b15988179a57c3cf3a878f668e1070cb615749fe52ae",
"addresses": [
"n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
"mmSKNtbYYHRrhTLKiok5TuYrGEs4Y2A4k6"
],
"sigsrequired": 2,
"account": ""
}
```
Wladimir J. van der Laan [Wed, 22 Oct 2014 07:25:08 +0000 (09:25 +0200)]
rpc: make `gettxoutsettinfo` run lock-free
For leveldb "An iterator operates on a snapshot of the database taken
when the iterator is created". This means that it is unnecessary to
lock out other threads while computing statistics, and neither to hold
cs_main for the whole time. Let the thread run free.
Jonas Schnelli [Fri, 19 Jun 2015 14:32:22 +0000 (16:32 +0200)]
fix lock issue for QT node diconnect and RPC disconnectnode
Zcash: only RPC disconnectnode
Jonas Schnelli [Fri, 19 Jun 2015 11:51:42 +0000 (13:51 +0200)]
setban: add IPv6 tests
Jonas Schnelli [Fri, 19 Jun 2015 11:31:33 +0000 (13:31 +0200)]
fix missing lock in CNode::ClearBanned()
Jonas Schnelli [Tue, 16 Jun 2015 16:21:03 +0000 (18:21 +0200)]
add RPC tests for setban & disconnectnode
Jonas Schnelli [Fri, 12 Jun 2015 20:27:03 +0000 (22:27 +0200)]
setban: add RPCErrorCode
Jonas Schnelli [Fri, 12 Jun 2015 17:51:50 +0000 (19:51 +0200)]
fix CSubNet comparison operator
Jonas Schnelli [Fri, 12 Jun 2015 16:31:47 +0000 (18:31 +0200)]
setban: rewrite to UniValue, allow absolute bantime
Jonas Schnelli [Fri, 12 Jun 2015 15:42:32 +0000 (17:42 +0200)]
rename json field "bannedtill" to "banned_until"
Jonas Schnelli [Mon, 25 May 2015 18:03:51 +0000 (20:03 +0200)]
[RPC] extend setban to allow subnets
Jonas Schnelli [Tue, 19 May 2015 15:15:25 +0000 (17:15 +0200)]
[net] remove unused return type bool from CNode::Ban()
Jonas Schnelli [Tue, 19 May 2015 08:20:31 +0000 (10:20 +0200)]
[QA] add setban/listbanned/clearbanned tests
Jonas Schnelli [Tue, 19 May 2015 08:07:46 +0000 (10:07 +0200)]
[RPC] add setban/listbanned/clearbanned RPC commands
Jonas Schnelli [Tue, 19 May 2015 08:07:23 +0000 (10:07 +0200)]
[net] extend core functionallity for ban/unban/listban
Alex van der Peet [Fri, 12 Jun 2015 03:20:54 +0000 (20:20 -0700)]
New RPC command disconnectnode
Stephen [Thu, 11 Jun 2015 20:12:34 +0000 (16:12 -0400)]
Add paytxfee to getwalletinfo, warnings to getnetworkinfo
Daniel Kraft [Wed, 10 Jun 2015 12:57:57 +0000 (14:57 +0200)]
Fix univalue handling of \u0000 characters.
Univalue's parsing of \u escape sequences did not handle NUL characters
correctly. They were, effectively, dropped. The extended test-case
fails with the old code, and is fixed with this patch.
zkbot [Thu, 2 Mar 2017 21:07:20 +0000 (21:07 +0000)]
Auto merge of #2138 - daira:2137.compactsize-portability.0, r=arcalinea
Don't assume sizes of unsigned short and unsigned int in GetSizeOfCompactSize and WriteCompactSize.
Fixes #2137
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
zkbot [Thu, 2 Mar 2017 19:20:10 +0000 (19:20 +0000)]
Auto merge of #2124 - str4d:2086-help2man, r=str4d
Improve autogenerated manpages
Cherry-picked from bitcoin/bitcoin#8608.
Closes #2086.
Jack Grigg [Thu, 23 Feb 2017 02:28:39 +0000 (02:28 +0000)]
Update release process with gen-manpages.sh
Jack Grigg [Thu, 23 Feb 2017 01:40:28 +0000 (01:40 +0000)]
Regenerate and collate Zcash manpages, delete Bitcoin ones
Jack Grigg [Thu, 23 Feb 2017 01:23:44 +0000 (01:23 +0000)]
Adjust gen-manpages.sh for Zcash, use in Debian builds
nomnombtc [Thu, 1 Sep 2016 14:51:24 +0000 (16:51 +0200)]
improved gen-manpages.sh, includes bitcoin-tx and strips commit tag, now also runs binaries from build dir by default, added variables for more control
nomnombtc [Thu, 1 Sep 2016 14:36:38 +0000 (16:36 +0200)]
regenerated all manpages with commit tag stripped, also add bitcoin-tx
nomnombtc [Sun, 28 Aug 2016 00:46:36 +0000 (02:46 +0200)]
change help string --enable-man to --disable-man
nomnombtc [Fri, 26 Aug 2016 23:12:41 +0000 (01:12 +0200)]
add conditional for --enable-man, default is yes
zkbot [Thu, 2 Mar 2017 06:47:04 +0000 (06:47 +0000)]
Auto merge of #2014 - arcalinea:test-prioritisetransaction, r=arcalinea
Test prioritisetransaction
After talking with @str4d about #1884 , I wrote a test for prioritisetransaction. It uses small blocks (11kb), and checks whether a transaction makes it into the next block after being prioritized by that node.
Should this be improved with a larger number of txs in the mempool, or by testing over multiple runs?
As for getblocktemplate(), it seems to return the prioritized transaction within the block size set by the node (about 50 txs fit in an 11kb block), but the block "sizelimit" it displays is set at 2 MB in `rpcmining.cpp` line 690:
```
result.push_back(Pair("sizelimit", (int64_t)MAX_BLOCK_SIZE));
```
This was quite confusing, I didn't think the `-blockmaxsize` parameter I was setting was working for awhile.
zkbot [Thu, 2 Mar 2017 03:51:14 +0000 (03:51 +0000)]
Auto merge of #2141 - bitcartel:1969_free_rate_limiter, r=daira
Closes #1969. Large shielded transactions using the default fee are no longer treated as "free" transactions
zkbot [Thu, 2 Mar 2017 03:08:29 +0000 (03:08 +0000)]
Auto merge of #2130 - str4d:2095-metrics-reindex-msg, r=arcalinea
Do not ask a UI question on metrics screen
Based on bitcoin/bitcoin#8257.
Closes #2095.
zkbot [Thu, 2 Mar 2017 02:18:33 +0000 (02:18 +0000)]
Auto merge of #2114 - bitcartel:fix_fr_test_bug_and_new_testnet_addresses, r=daira
Closes #2113. Fixes bug in test and updates testnet fr addresses.
Updating the testnet fr addresses will introduce a consensus change on testnet, so all testnet nodes will be required to upgrade. See #2113 for more information.
zkbot [Thu, 2 Mar 2017 01:23:44 +0000 (01:23 +0000)]
Auto merge of #1932 - aniemerg:1522-pause-mining-for-joinsplit, r=arcalinea
Pause mining during JoinSplit creation
Closes #1522 .
Allan Niemerg [Mon, 5 Dec 2016 03:05:30 +0000 (21:05 -0600)]
Pause mining during joinsplit creation
zkbot [Thu, 2 Mar 2017 00:24:26 +0000 (00:24 +0000)]
Auto merge of #2123 - bitcartel:2112_z_getoperationresult_returns_executing_status, r=arcalinea
Closes #2112 where z_getoperationresult could return stale status.
The problem was similar to a check-then-act race condition. Status object was obtained from an operation, which might be in an 'executing' state. Instead of checking the state recorded in the status object, the operation was queried again to see if it was in a finished state (failed,success,cancelled) and if yes, the status object was returned to the user. However, if the operation had changed state in the background, the status object would be stale.
This page took 0.102748 seconds and 4 git commands to generate.