]> Git Repo - VerusCoin.git/log
VerusCoin.git
6 years agomake-release.py: Updated release notes and changelog for 1.1.1-rc2.
Simon [Wed, 23 May 2018 16:28:50 +0000 (09:28 -0700)]
make-release.py: Updated release notes and changelog for 1.1.1-rc2.

6 years agomake-release.py: Updated manpages for 1.1.1-rc2.
Simon [Wed, 23 May 2018 16:28:49 +0000 (09:28 -0700)]
make-release.py: Updated manpages for 1.1.1-rc2.

6 years agomake-release.py: Versioning changes for 1.1.1-rc2.
Simon [Wed, 23 May 2018 16:27:59 +0000 (09:27 -0700)]
make-release.py: Versioning changes for 1.1.1-rc2.

6 years agoAuto merge of #3286 - str4d:3153-gitian-fix, r=str4d
Homu [Tue, 22 May 2018 23:49:51 +0000 (16:49 -0700)]
Auto merge of #3286 - str4d:3153-gitian-fix, r=str4d

Comment out Gitian library handling while we don't build any libraries

Fixes a Gitian build failure introduced by #3153.

6 years agoComment out Gitian library handling while we don't build any libraries
Jack Grigg [Tue, 22 May 2018 06:37:47 +0000 (18:37 +1200)]
Comment out Gitian library handling while we don't build any libraries

Fixes a Gitian build failure introduced by #3153.

6 years agoAuto merge of #3279 - str4d:release-v1.1.1-rc1, r=str4d
Homu [Sat, 19 May 2018 00:11:28 +0000 (17:11 -0700)]
Auto merge of #3279 - str4d:release-v1.1.1-rc1, r=str4d

Release v1.1.1-rc1

6 years agomake-release.py: Updated release notes and changelog for 1.1.1-rc1.
Jack Grigg [Fri, 18 May 2018 22:16:15 +0000 (10:16 +1200)]
make-release.py: Updated release notes and changelog for 1.1.1-rc1.

6 years agomake-release.py: Updated manpages for 1.1.1-rc1.
Jack Grigg [Fri, 18 May 2018 22:16:14 +0000 (10:16 +1200)]
make-release.py: Updated manpages for 1.1.1-rc1.

6 years agomake-release.py: Versioning changes for 1.1.1-rc1.
Jack Grigg [Fri, 18 May 2018 21:50:15 +0000 (09:50 +1200)]
make-release.py: Versioning changes for 1.1.1-rc1.

6 years agoAuto merge of #3275 - ebfull:little-endian, r=str4d
Homu [Fri, 18 May 2018 20:03:44 +0000 (13:03 -0700)]
Auto merge of #3275 - ebfull:little-endian, r=str4d

Circuit change for endianness

This PR changes the circuit, encodings and parameters to match the encodings specified in the protocol spec. You'll want to `rm ~/.zcash-params/*.params` and run `./zcutil/fetch-params.sh --testnet` to switch to the new parameters for testnet.

6 years agoChange txdb prefixes for sapling and avoid writing unnecessary information.
Sean Bowe [Thu, 17 May 2018 23:54:31 +0000 (17:54 -0600)]
Change txdb prefixes for sapling and avoid writing unnecessary information.

6 years agoUpdate merkle tree and pedersen hash tests to account for new encoding
Sean Bowe [Thu, 17 May 2018 23:45:08 +0000 (17:45 -0600)]
Update merkle tree and pedersen hash tests to account for new encoding

6 years agoUpdate Sapling testnet parameters
Sean Bowe [Thu, 17 May 2018 23:17:19 +0000 (17:17 -0600)]
Update Sapling testnet parameters

6 years agoUpdate librustzcash
Sean Bowe [Thu, 17 May 2018 23:17:11 +0000 (17:17 -0600)]
Update librustzcash

6 years agoAuto merge of #3238 - str4d:3199-mempool-sapling-activation, r=str4d
Homu [Wed, 16 May 2018 20:52:40 +0000 (13:52 -0700)]
Auto merge of #3238 - str4d:3199-mempool-sapling-activation, r=str4d

Update mempool_nu_activation RPC test to exercise both Overwinter and Sapling

Closes #3199.

6 years agoAuto merge of #3255 - str4d:sapling-value-pool, r=ebfull
Homu [Wed, 16 May 2018 17:46:32 +0000 (10:46 -0700)]
Auto merge of #3255 - str4d:sapling-value-pool, r=ebfull

Track net value entering and exiting the Sapling circuit

6 years agoAuto merge of #3271 - ebfull:stable-rust, r=bitcartel
Homu [Wed, 16 May 2018 04:27:53 +0000 (21:27 -0700)]
Auto merge of #3271 - ebfull:stable-rust, r=bitcartel

Switch Rust to 1.26 Stable

6 years agoAuto merge of #3251 - ebfull:sprout-groth16, r=ebfull
Homu [Tue, 15 May 2018 22:48:19 +0000 (15:48 -0700)]
Auto merge of #3251 - ebfull:sprout-groth16, r=ebfull

Sprout on Groth16

Depends on https://github.com/zcash/librustzcash/pull/6

6 years agoSwitch Rust to 1.26 Stable.
Sean Bowe [Tue, 15 May 2018 22:21:37 +0000 (16:21 -0600)]
Switch Rust to 1.26 Stable.

6 years agofix qa/zcash/full_test_suite.py pathname
Larry Ruane [Mon, 14 May 2018 22:50:42 +0000 (16:50 -0600)]
fix qa/zcash/full_test_suite.py pathname

underscores instead of hyphens; .py instead of .sh
(did not bother with PR but Eirik reviewed this change)

6 years agoCorrectly serialize Groth16 JSDescription for verifyjoinsplit benchmark
Jack Grigg [Fri, 11 May 2018 17:27:21 +0000 (13:27 -0400)]
Correctly serialize Groth16 JSDescription for verifyjoinsplit benchmark

6 years agoAdjust tests and benchmarks
Sean Bowe [Fri, 11 May 2018 12:42:35 +0000 (06:42 -0600)]
Adjust tests and benchmarks

6 years agoUpdate librustzcash again
Sean Bowe [Fri, 11 May 2018 12:34:07 +0000 (06:34 -0600)]
Update librustzcash again

6 years agoIntegrate Groth16 verification and proving.
Sean Bowe [Wed, 9 May 2018 01:56:34 +0000 (19:56 -0600)]
Integrate Groth16 verification and proving.

6 years agoAuto merge of #3264 - sembrestels:patch-1, r=bitcartel
Homu [Mon, 14 May 2018 18:14:05 +0000 (11:14 -0700)]
Auto merge of #3264 - sembrestels:patch-1, r=bitcartel

Update Payment API

I included those missing commands to the API reference: `z_exportviewingkey`, `z_importviewingkey`, and `z_listunspent`.

Do you think we should include `z_mergetoaddress`, `z_getpaymentdisclosure`, and `z_validatepaymentdisclosure` too, despite they are experimental?

6 years agoUpdate Payment API
David Llop [Mon, 14 May 2018 13:37:08 +0000 (15:37 +0200)]
Update Payment API

I included those missing commands to the API reference: `z_exportviewingkey`, `z_importviewingkey`, and `z_listunspent`.

Do you think we should include `z_mergetoaddress`, `z_getpaymentdisclosure`, and `z_validatepaymentdisclosure` too, despite they are experimental?

6 years agoAuto merge of #3234 - str4d:3058-address-polymorphism, r=str4d
Homu [Sat, 12 May 2018 11:06:27 +0000 (04:06 -0700)]
Auto merge of #3234 - str4d:3058-address-polymorphism, r=str4d

Use boost::variant to represent shielded addresses and keys

Part of #3058 and #3059.

6 years agoUse boost::variant to represent shielded addresses and keys
Jack Grigg [Thu, 26 Apr 2018 01:51:17 +0000 (02:51 +0100)]
Use boost::variant to represent shielded addresses and keys

libzcash::PaymentAddress has been renamed to libzcash::SproutPaymentAddress,
and a new typedef boost::variant is now libzcash::PaymentAddress. Similarly
for ViewingKey and SpendingKey.

A new class InvalidEncoding is introduced as the default boost::variant
option for each address and key type; it is used during decoding instead
of boost::optional.

All address and key storage functions in the wallet have been modified to
refer specifically to the Sprout types, as they are used very precisely.
In most other cases, the more general type is leveraged as much as possible,
and we convert to the Sprout type when necessary. This will be subsequently
wrapped in, or replaced with, context-specific functions once Sapling
types are implemented.

6 years agoAuto merge of #3242 - str4d:3058-key-encoding-refactor, r=str4d
Homu [Fri, 11 May 2018 19:21:29 +0000 (12:21 -0700)]
Auto merge of #3242 - str4d:3058-key-encoding-refactor, r=str4d

Key encoding refactor

Includes code cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#11372
  - Only the first three commits (the fourth commit depends on #2390)

Part of #3058.

6 years agoAuto merge of #3232 - ebfull:3207-sapling-validation, r=str4d
Homu [Thu, 10 May 2018 17:21:15 +0000 (10:21 -0700)]
Auto merge of #3232 - ebfull:3207-sapling-validation, r=str4d

Sapling validation

**Also review https://github.com/zcash/librustzcash/pull/7**

This is an attempt to tackle much of https://github.com/zcash/zcash/issues/3065

6 years agoAuto merge of #3257 - bitcartel:3250_fix_segfault_memo, r=ebfull
Homu [Thu, 10 May 2018 15:47:06 +0000 (08:47 -0700)]
Auto merge of #3257 - bitcartel:3250_fix_segfault_memo, r=ebfull

Closes #3250. Memo getter should return by reference, not by value.

6 years agoAuto merge of #3247 - str4d:3207-valuebalance, r=str4d
Homu [Thu, 10 May 2018 14:12:00 +0000 (07:12 -0700)]
Auto merge of #3247 - str4d:3207-valuebalance, r=str4d

Add valueBalance to value balances

Part of #3065 and #3207.

6 years agoAdd contextual comment for GetValueOut() and GetShieldedValueIn()
Jack Grigg [Thu, 10 May 2018 13:34:19 +0000 (09:34 -0400)]
Add contextual comment for GetValueOut() and GetShieldedValueIn()

6 years agoCloses #3250. Memo getter should return by reference, not by value.
Simon [Thu, 10 May 2018 04:52:33 +0000 (21:52 -0700)]
Closes #3250. Memo getter should return by reference, not by value.

6 years agoAuto merge of #3240 - str4d:remove-obsolete-binaries, r=str4d
Homu [Wed, 9 May 2018 20:50:25 +0000 (13:50 -0700)]
Auto merge of #3240 - str4d:remove-obsolete-binaries, r=str4d

Remove obsolete CreateJoinSplit and GenerateParams binaries

6 years agoTrack net value entering and exiting the Sapling circuit
Jack Grigg [Wed, 9 May 2018 11:15:46 +0000 (12:15 +0100)]
Track net value entering and exiting the Sapling circuit

6 years agoAdd valueBalance to value balances, and enforce its consensus rules
Jack Grigg [Tue, 8 May 2018 12:51:54 +0000 (13:51 +0100)]
Add valueBalance to value balances, and enforce its consensus rules

6 years agoAuto merge of #3233 - str4d:3164-sapling-sighash, r=str4d
Homu [Tue, 8 May 2018 23:59:33 +0000 (16:59 -0700)]
Auto merge of #3233 - str4d:3164-sapling-sighash, r=str4d

ZIP 243: Sapling SignatureHash

Closes #3164.

6 years agoAdd key_io includes to Zcash-specific code
Jack Grigg [Wed, 25 Apr 2018 11:58:22 +0000 (12:58 +0100)]
Add key_io includes to Zcash-specific code

6 years agoSplit key_io (address/key encodings) off from base58
Pieter Wuille [Wed, 20 Sep 2017 01:12:25 +0000 (18:12 -0700)]
Split key_io (address/key encodings) off from base58

6 years agoStop using CBase58Data for ext keys
Pieter Wuille [Wed, 20 Sep 2017 00:13:46 +0000 (17:13 -0700)]
Stop using CBase58Data for ext keys

6 years agoImplement {Encode,Decode}PaymentAddress etc. without CZCEncoding
Jack Grigg [Tue, 24 Apr 2018 22:45:04 +0000 (23:45 +0100)]
Implement {Encode,Decode}PaymentAddress etc. without CZCEncoding

6 years agoIntroduce wrappers around CZCViewingKey
Jack Grigg [Tue, 24 Apr 2018 21:53:54 +0000 (22:53 +0100)]
Introduce wrappers around CZCViewingKey

6 years agoIntroduce wrappers around CZCSpendingKey
Jack Grigg [Tue, 24 Apr 2018 14:16:27 +0000 (15:16 +0100)]
Introduce wrappers around CZCSpendingKey

6 years agoIntroduce wrappers around CZCPaymentAddress
Jack Grigg [Tue, 24 Apr 2018 14:01:45 +0000 (15:01 +0100)]
Introduce wrappers around CZCPaymentAddress

This patch removes the need for the intermediary Base58 type
CZCPaymentAddress, by providing {Encode,Decode}PaymentAddress
functions that directly operate on the conversion between strings
and libzcash::PaymentAddress.

6 years agoReplace CBitcoinSecret with {Encode,Decode}Secret
Pieter Wuille [Tue, 19 Sep 2017 23:49:52 +0000 (16:49 -0700)]
Replace CBitcoinSecret with {Encode,Decode}Secret

6 years agoCheck Sapling Spend/Output proofs and signatures.
Sean Bowe [Tue, 8 May 2018 20:28:55 +0000 (14:28 -0600)]
Check Sapling Spend/Output proofs and signatures.

6 years agoUpdate to latest librustzcash
Sean Bowe [Tue, 8 May 2018 20:29:58 +0000 (14:29 -0600)]
Update to latest librustzcash

6 years agoRefactor so that dataToBeSigned can be used later in the function for other purposes.
Sean Bowe [Tue, 8 May 2018 20:28:01 +0000 (14:28 -0600)]
Refactor so that dataToBeSigned can be used later in the function for other purposes.

6 years agoRemove unnecessary IsCoinbase() check. Coinbases are guaranteed to have empty vjoinsplit.
Sean Bowe [Tue, 8 May 2018 20:23:09 +0000 (14:23 -0600)]
Remove unnecessary IsCoinbase() check. Coinbases are guaranteed to have empty vjoinsplit.

6 years agoAuto merge of #3202 - str4d:3058-sapling-bech32, r=str4d
Homu [Tue, 8 May 2018 16:08:37 +0000 (09:08 -0700)]
Auto merge of #3202 - str4d:3058-sapling-bech32, r=str4d

Bech32 encoding support

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#8578
- bitcoin/bitcoin#11167
  - Only the second and third commits (first is in #3228, fourth depends on #2390, later ones are SegWit-specific).
- bitcoin/bitcoin#12757
  - Only the change to `src/bech32.h`

Part of #3058.

6 years agoAuto merge of #3201 - Eirik0:3190-dumpprivkey-help-text, r=str4d
Homu [Tue, 8 May 2018 13:02:17 +0000 (06:02 -0700)]
Auto merge of #3201 - Eirik0:3190-dumpprivkey-help-text, r=str4d

Clarify help text of dumpprivkey

Closes #3190

6 years agoUpdate sighash tests
Jack Grigg [Tue, 1 May 2018 22:56:53 +0000 (23:56 +0100)]
Update sighash tests

6 years agoImplement Sapling signature hash (ZIP 243)
Jack Grigg [Tue, 1 May 2018 22:10:58 +0000 (23:10 +0100)]
Implement Sapling signature hash (ZIP 243)

6 years agoAuto merge of #3236 - str4d:3192-jsoutpoint-constructor, r=str4d
Homu [Tue, 8 May 2018 09:50:04 +0000 (02:50 -0700)]
Auto merge of #3236 - str4d:3192-jsoutpoint-constructor, r=str4d

Change JSOutPoint constructor to have js argument be uint64_t

Closes #3192.

6 years agoAuto merge of #3170 - ebfull:sapling-merkle-tree, r=ebfull
Homu [Tue, 8 May 2018 03:37:46 +0000 (20:37 -0700)]
Auto merge of #3170 - ebfull:sapling-merkle-tree, r=ebfull

Sapling merkle tree implementation

Closes #3056.

Please also review https://github.com/zcash/librustzcash/pull/8

This PR:

1. Introduces ZCSaplingIncrementalMerkleTree using Pedersen hashes.
2. Adds support for Sapling anchors into consensus rules. (Adds commitments, checks anchors are correct, handles block (dis)connects, etc.)
3. Handles mempool eviction for obsolete anchors.
4. Enforces correctness of block's Sapling root field
5. Changes miner to correctly apply the Sapling root to the block header
6. Handles mempool consistency checks for anchors

6 years agoSwap bit endianness of test vectors
Sean Bowe [Tue, 8 May 2018 00:57:04 +0000 (18:57 -0600)]
Swap bit endianness of test vectors

6 years agoUpdate sapling-crypto and librustzcash
Sean Bowe [Tue, 8 May 2018 00:56:55 +0000 (18:56 -0600)]
Update sapling-crypto and librustzcash

6 years agowallet: Make some arguments const that can be
Jack Grigg [Mon, 7 May 2018 21:13:26 +0000 (22:13 +0100)]
wallet: Make some arguments const that can be

6 years agowallet: Change IsLockedNote to take a JSOutPoint
Jack Grigg [Mon, 7 May 2018 20:56:57 +0000 (21:56 +0100)]
wallet: Change IsLockedNote to take a JSOutPoint

This removes the uint64_t -> size_t -> uint64_t round trip, as well as the
JSOutPoint -> parts -> JSOutPoint round trip.

6 years agoFix miner tests
Sean Bowe [Mon, 7 May 2018 20:30:20 +0000 (14:30 -0600)]
Fix miner tests

6 years agoFix broken error messages.
Sean Bowe [Mon, 7 May 2018 19:49:17 +0000 (13:49 -0600)]
Fix broken error messages.

6 years agoFix outdated comment
Sean Bowe [Mon, 7 May 2018 19:43:55 +0000 (13:43 -0600)]
Fix outdated comment

6 years agoEvict transactions with obsolete anchors from the mempool
Sean Bowe [Mon, 7 May 2018 06:16:14 +0000 (00:16 -0600)]
Evict transactions with obsolete anchors from the mempool

6 years agoAdjust tests to handle Sapling anchor cache
Sean Bowe [Mon, 7 May 2018 06:00:39 +0000 (00:00 -0600)]
Adjust tests to handle Sapling anchor cache

6 years agoCalculate the correct hashFinalSaplingRoot in the miner.
Sean Bowe [Mon, 7 May 2018 05:37:48 +0000 (23:37 -0600)]
Calculate the correct hashFinalSaplingRoot in the miner.

6 years agoAdd support for Sapling anchor checks in mempool consistency checks.
Sean Bowe [Mon, 7 May 2018 05:29:29 +0000 (23:29 -0600)]
Add support for Sapling anchor checks in mempool consistency checks.

6 years agoAdd consensus support for Sapling merkle trees.
Sean Bowe [Mon, 7 May 2018 05:27:52 +0000 (23:27 -0600)]
Add consensus support for Sapling merkle trees.

6 years agoAdd `PushSaplingAnchor`
Sean Bowe [Mon, 7 May 2018 03:38:45 +0000 (21:38 -0600)]
Add `PushSaplingAnchor`

6 years agoAdd support for PopAnchor(.., SPROUT/SAPLING)
Sean Bowe [Mon, 7 May 2018 01:05:11 +0000 (19:05 -0600)]
Add support for PopAnchor(.., SPROUT/SAPLING)

6 years agoAdd support for Sapling anchors in coins/txdb.
Sean Bowe [Mon, 7 May 2018 00:45:05 +0000 (18:45 -0600)]
Add support for Sapling anchors in coins/txdb.

6 years agoRename hashSproutAnchorEnd to hashFinalSproutRoot to be consistent.
Sean Bowe [Sun, 6 May 2018 21:21:49 +0000 (15:21 -0600)]
Rename hashSproutAnchorEnd to hashFinalSproutRoot to be consistent.

6 years agoRename hashSaplingAnchorEnd to hashFinalSaplingRoot to match spec.
Sean Bowe [Sun, 6 May 2018 21:19:28 +0000 (15:19 -0600)]
Rename hashSaplingAnchorEnd to hashFinalSaplingRoot to match spec.

6 years agoRemove underscores from gtest test names.
Sean Bowe [Sun, 6 May 2018 20:26:54 +0000 (14:26 -0600)]
Remove underscores from gtest test names.

6 years agoGeneralize the PushAnchor implementation behavior.
Sean Bowe [Fri, 27 Apr 2018 22:52:33 +0000 (16:52 -0600)]
Generalize the PushAnchor implementation behavior.

6 years agoGeneralize the PopAnchor implementation behavior.
Sean Bowe [Fri, 27 Apr 2018 22:31:12 +0000 (16:31 -0600)]
Generalize the PopAnchor implementation behavior.

6 years agoIntroduce support for GetBestAnchor(SAPLING).
Sean Bowe [Fri, 27 Apr 2018 22:00:21 +0000 (16:00 -0600)]
Introduce support for GetBestAnchor(SAPLING).

6 years agoRename PushAnchor to PushSproutAnchor.
Sean Bowe [Fri, 27 Apr 2018 21:18:04 +0000 (15:18 -0600)]
Rename PushAnchor to PushSproutAnchor.

6 years agoRename GetAnchorAt to GetSproutAnchorAt.
Sean Bowe [Fri, 27 Apr 2018 21:00:00 +0000 (15:00 -0600)]
Rename GetAnchorAt to GetSproutAnchorAt.

6 years agoRename DB_ANCHOR to DB_SPROUT_ANCHOR.
Sean Bowe [Fri, 27 Apr 2018 20:34:31 +0000 (14:34 -0600)]
Rename DB_ANCHOR to DB_SPROUT_ANCHOR.

6 years agoAdd primitive implementation of GetSaplingAnchorEnd.
Sean Bowe [Fri, 27 Apr 2018 20:29:40 +0000 (14:29 -0600)]
Add primitive implementation of GetSaplingAnchorEnd.

6 years agoRename hashReserved to hashSaplingAnchorEnd.
Sean Bowe [Fri, 27 Apr 2018 20:11:32 +0000 (14:11 -0600)]
Rename hashReserved to hashSaplingAnchorEnd.

6 years agoRename hashAnchor to hashSproutAnchor.
Sean Bowe [Thu, 26 Apr 2018 01:15:30 +0000 (19:15 -0600)]
Rename hashAnchor to hashSproutAnchor.

6 years agoSpecifically describe anchors as Sprout anchors.
Sean Bowe [Thu, 26 Apr 2018 00:38:34 +0000 (18:38 -0600)]
Specifically describe anchors as Sprout anchors.

6 years agoRename NullifierType to ShieldedType.
Sean Bowe [Wed, 25 Apr 2018 23:55:33 +0000 (17:55 -0600)]
Rename NullifierType to ShieldedType.

6 years agoAdd regression tests and test vectors for Sapling merkle tree
Sean Bowe [Wed, 18 Apr 2018 04:59:41 +0000 (22:59 -0600)]
Add regression tests and test vectors for Sapling merkle tree

6 years agoAdd implementation of Sapling merkle tree
Sean Bowe [Sun, 15 Apr 2018 04:33:41 +0000 (22:33 -0600)]
Add implementation of Sapling merkle tree

6 years agoAbstract `uncommitted` and depth personalization for IncrementalMerkleTree.
Sean Bowe [Thu, 12 Apr 2018 23:10:04 +0000 (17:10 -0600)]
Abstract `uncommitted` and depth personalization for IncrementalMerkleTree.

6 years agoAuto merge of #3239 - str4d:sapling-default-tx-version, r=str4d
Homu [Mon, 7 May 2018 19:27:47 +0000 (12:27 -0700)]
Auto merge of #3239 - str4d:sapling-default-tx-version, r=str4d

Update CreateNewContextualCMutableTransaction for Sapling

Part of #3063.

6 years agoUpdate tests for CreateNewContextualCMutableTransaction changes
Jack Grigg [Thu, 3 May 2018 12:48:20 +0000 (13:48 +0100)]
Update tests for CreateNewContextualCMutableTransaction changes

6 years agoAuto merge of #3212 - str4d:2864-sapling-tx-size-limit, r=str4d
Homu [Mon, 7 May 2018 09:20:42 +0000 (02:20 -0700)]
Auto merge of #3212 - str4d:2864-sapling-tx-size-limit, r=str4d

Raise 100kB transaction size limit from Sapling activation

Closes #2864.

6 years agoAuto merge of #2894 - per-gron:dont-export-unless-needed, r=str4d
Homu [Fri, 4 May 2018 22:05:43 +0000 (15:05 -0700)]
Auto merge of #2894 - per-gron:dont-export-unless-needed, r=str4d

Make some globals static that can be

I wrote this patch as part of making a Bazel build system but it really is independent from that so I'm putting this as a separate PR.

External linkage does not help and just encourages sloppy dependencies (ie using symbols only declared in a cpp file in some other cpp file) and can lead to weird issues when there are name collisions.

6 years agoAdd test of Sapling transaction size boundary
Jack Grigg [Tue, 1 May 2018 19:15:04 +0000 (20:15 +0100)]
Add test of Sapling transaction size boundary

6 years agoRework z_sendmany z-address recipient limit
Jack Grigg [Tue, 1 May 2018 10:23:11 +0000 (11:23 +0100)]
Rework z_sendmany z-address recipient limit

From Sapling, the z-address recipients could require either JSDescriptions or
OutputDescriptions. Instead of trying to give an exact number in the help text,
rely on transaction size estimation to guide user behaviour.

6 years agoRename MAX_TX_SIZE to MAX_TX_SIZE_AFTER_SAPLING
Jack Grigg [Mon, 30 Apr 2018 14:13:32 +0000 (15:13 +0100)]
Rename MAX_TX_SIZE to MAX_TX_SIZE_AFTER_SAPLING

6 years agoBenchmark the largest valid Sapling transaction in validatelargetx
Jack Grigg [Thu, 26 Apr 2018 14:05:10 +0000 (15:05 +0100)]
Benchmark the largest valid Sapling transaction in validatelargetx

11130 inputs results in a transaction between 1992301 and 2003431 bytes.

6 years agoRaise 100kB transaction size limit from Sapling activation
Jack Grigg [Thu, 26 Apr 2018 13:18:36 +0000 (14:18 +0100)]
Raise 100kB transaction size limit from Sapling activation

Closes #2864.

6 years agoAdd missing include guard
Jack Grigg [Fri, 4 May 2018 09:37:14 +0000 (10:37 +0100)]
Add missing include guard

Extracted from bitcoin/bitcoin#12757
- Commit 8fd6af89a0c061d79bb3fd2ba704b61dcc2e9211

6 years agoConvert base58_tests from type/payload to scriptPubKey comparison
Pieter Wuille [Tue, 19 Sep 2017 22:30:11 +0000 (15:30 -0700)]
Convert base58_tests from type/payload to scriptPubKey comparison

6 years agoImport Bech32 C++ reference code & tests
Pieter Wuille [Sat, 26 Aug 2017 01:12:39 +0000 (18:12 -0700)]
Import Bech32 C++ reference code & tests

This includes a reformatted version of the Bech32 reference code
(see https://github.com/sipa/bech32/tree/master/ref/c%2B%2B), with
extra documentation.

This page took 0.060018 seconds and 4 git commands to generate.