]> Git Repo - VerusCoin.git/log
VerusCoin.git
7 years agoAdd a benchmark for calling ConnectBlock on a block with many inputs
Jack Grigg [Fri, 12 May 2017 01:00:15 +0000 (13:00 +1200)]
Add a benchmark for calling ConnectBlock on a block with many inputs

Requires placing block-107134.tar.gz (containing the block, and a fake CoinsDB
containing its inputs) into the base directory of the repository. This can be
generated using qa/zcash/create_benchmark_archive.py (see the script for usage
details).

To facilitate generation of the fake CoinsDB, an additional field 'valueZat' has
been added to 'getrawtransaction' containing the integer number of zatoshis
instead of a decimal number of ZEC.

Closes #2355.

7 years agoAuto merge of #2200 - str4d:1884-tx-priority-test, r=nathan-at-least
Homu [Tue, 16 May 2017 18:54:49 +0000 (11:54 -0700)]
Auto merge of #2200 - str4d:1884-tx-priority-test, r=nathan-at-least

Fix prioritisetransaction RPC test

Part of #1884.

7 years agoRegenerate miner tests
Jack Grigg [Thu, 11 May 2017 22:17:15 +0000 (10:17 +1200)]
Regenerate miner tests

Closes #2271.

7 years agoAuto merge of #2293 - daira:alerts-for-2017-04-11.a, r=nathan-at-least
Homu [Mon, 15 May 2017 23:08:29 +0000 (16:08 -0700)]
Auto merge of #2293 - daira:alerts-for-2017-04-11.a, r=nathan-at-least

Alerts for 2017-04-11.a security issue (fixed in 1.0.8-1)

Alert 1002 (versions 1.0.0-1.0.2 inclusive).
Alert 1003 (versions 1.0.3-1.0.8 inclusive).

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoAuto merge of #2369 - nathan-at-least:build-toolchain-logging, r=nathan-at-least
Homu [Mon, 15 May 2017 20:12:05 +0000 (13:12 -0700)]
Auto merge of #2369 - nathan-at-least:build-toolchain-logging, r=nathan-at-least

Print toolchain versions before making depends, autoconf, or main build.

Closes #2218.

Note: I spent a half hour attempting to have make do this so that people not using `build.sh` would get the same output. There's no easy way I found to ensure that output occurs first and regardless of the result of other build rules.

7 years agoAuto merge of #2340 - ioptio:master, r=nathan-at-least
Homu [Mon, 15 May 2017 18:19:40 +0000 (11:19 -0700)]
Auto merge of #2340 - ioptio:master, r=nathan-at-least

wallet backup instructions

closes #2178

7 years agoAuto merge of #2338 - amgadabdelhafez:patch-1, r=nathan-at-least
Homu [Mon, 15 May 2017 16:42:19 +0000 (09:42 -0700)]
Auto merge of #2338 - amgadabdelhafez:patch-1, r=nathan-at-least

Update timedata.cpp to fix error message string from bitcoin core to zcash

Changing error message string from bitcoin core to zcash. fixes issue #2336

7 years agoAuto merge of #2297 - str4d:2274-apoptosis, r=nathan-at-least
Homu [Mon, 15 May 2017 01:39:14 +0000 (18:39 -0700)]
Auto merge of #2297 - str4d:2274-apoptosis, r=nathan-at-least

Implement automatic shutdown of deprecated Zcash versions

Closes #2274.

7 years agoAuto merge of #2251 - str4d:2210-tor-quotedstring-escapes, r=nathan-at-least
Homu [Sat, 13 May 2017 22:24:58 +0000 (15:24 -0700)]
Auto merge of #2251 - str4d:2210-tor-quotedstring-escapes, r=nathan-at-least

Handle escapes in Tor QuotedStrings

Also adds a missing copyright header.

Closes #2210.

7 years agoAuto merge of #2362 - daira:2361.disable-proton-by-default, r=nathan-at-least
Homu [Sat, 13 May 2017 01:07:58 +0000 (18:07 -0700)]
Auto merge of #2362 - daira:2361.disable-proton-by-default, r=nathan-at-least

Disable building Proton by default

fixes #2361

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoShow toolchain versions in build.sh.
Nathan Wilcox [Fri, 12 May 2017 05:02:00 +0000 (22:02 -0700)]
Show toolchain versions in build.sh.

7 years agospecify exportdir being within homedirectory
Paige Peterson [Fri, 12 May 2017 02:43:01 +0000 (22:43 -0400)]
specify exportdir being within homedirectory

7 years agoWrap messages nicely on metrics screen
Jack Grigg [Thu, 11 May 2017 03:35:57 +0000 (15:35 +1200)]
Wrap messages nicely on metrics screen

7 years agoImplement automatic shutdown of deprecated Zcash versions
Jack Grigg [Tue, 25 Apr 2017 06:06:29 +0000 (18:06 +1200)]
Implement automatic shutdown of deprecated Zcash versions

Closes #2274.

7 years agostr4d and Ariel's suggestions
Paige Peterson [Thu, 11 May 2017 23:51:21 +0000 (19:51 -0400)]
str4d and Ariel's suggestions

7 years agoReplace bitcoind with zcashd
emilrus [Thu, 11 May 2017 08:41:13 +0000 (11:41 +0300)]
Replace bitcoind with zcashd

7 years agoRemove an unneeded version workaround as per @str4d's review comment.
Daira Hopwood [Thu, 11 May 2017 06:27:43 +0000 (07:27 +0100)]
Remove an unneeded version workaround as per @str4d's review comment.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoDisable building Proton by default.
Daira Hopwood [Wed, 10 May 2017 15:54:58 +0000 (16:54 +0100)]
Disable building Proton by default.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoUpdate timedata.cpp
Amgad Abdelhafez [Fri, 5 May 2017 15:24:48 +0000 (11:24 -0400)]
Update timedata.cpp

Capitalizing the 'z' in "Zcash" string

7 years agotypo and rewording edits
Paige Peterson [Thu, 4 May 2017 01:49:19 +0000 (21:49 -0400)]
typo and rewording edits

7 years agowallet backup instructions
Paige Peterson [Thu, 4 May 2017 01:25:06 +0000 (21:25 -0400)]
wallet backup instructions

7 years agoUpdate timedata.cpp
Amgad Abdelhafez [Tue, 2 May 2017 23:33:52 +0000 (19:33 -0400)]
Update timedata.cpp

Changing error message string from botcoin core to zcash

7 years agoPatch to build Proton with minimal dependencies.
Simon [Fri, 28 Apr 2017 01:11:24 +0000 (18:11 -0700)]
Patch to build Proton with minimal dependencies.

Closes #2279.  Configures CMake to enable C++11, build static libaries
and only build cpp bindings with minimal dependencies. Documentation,
examples, tests and other language bindings are no longer built.
CMake will no longer try to find commands and packages which are not
required for building the target.

7 years agoAlert 1003 (versions 1.0.3-1.0.8 inclusive).
Daira Hopwood [Mon, 24 Apr 2017 18:55:20 +0000 (19:55 +0100)]
Alert 1003 (versions 1.0.3-1.0.8 inclusive).

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoAlert 1002 (versions 1.0.0-1.0.2 inclusive).
Daira Hopwood [Mon, 24 Apr 2017 18:42:12 +0000 (19:42 +0100)]
Alert 1002 (versions 1.0.0-1.0.2 inclusive).

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoCheck that >3-digit octals are truncated.
Jack Grigg [Fri, 21 Apr 2017 01:23:29 +0000 (13:23 +1200)]
Check that >3-digit octals are truncated.

7 years agoCorrectly handle three-digit octals with leading digit 4-7
Jack Grigg [Fri, 21 Apr 2017 01:22:51 +0000 (13:22 +1200)]
Correctly handle three-digit octals with leading digit 4-7

7 years agoAddress Daira's further comments
Jack Grigg [Fri, 21 Apr 2017 01:15:39 +0000 (13:15 +1200)]
Address Daira's further comments

7 years agoAuto merge of #2270 - bitcartel:2269_change_regtest_port, r=daira
zkbot [Wed, 19 Apr 2017 11:07:49 +0000 (11:07 +0000)]
Auto merge of #2270 - bitcartel:2269_change_regtest_port, r=daira

Change regtest port to 18344.  Closes #2269.

7 years agoAddress Daira's comments
Jack Grigg [Wed, 19 Apr 2017 03:23:28 +0000 (15:23 +1200)]
Address Daira's comments

7 years ago[manpage] Handle build numbers in versions
Jack Grigg [Wed, 19 Apr 2017 01:56:32 +0000 (13:56 +1200)]
[manpage] Handle build numbers in versions

7 years agoConvert Zcash versions to Debian format
Jack Grigg [Wed, 8 Mar 2017 21:48:24 +0000 (10:48 +1300)]
Convert Zcash versions to Debian format

7 years agotorcontrol: Add missing copyright header
Jack Grigg [Tue, 11 Apr 2017 06:31:02 +0000 (18:31 +1200)]
torcontrol: Add missing copyright header

7 years agotorcontrol: Handle escapes in Tor QuotedStrings
Jack Grigg [Tue, 11 Apr 2017 06:30:42 +0000 (18:30 +1200)]
torcontrol: Handle escapes in Tor QuotedStrings

https://trac.torproject.org/projects/tor/ticket/14999 is tracking an encoding
bug with the Tor control protocol, where many of the QuotedString instances that
Tor outputs are in fact CStrings, but it is not documented which ones are which.

https://spec.torproject.org/control-spec section 2.1.1 provides a future-proofed
rule for handing QuotedStrings, which this commit implements.

7 years agoAuto merge of #2205 - arcalinea:1804_zcash_addresses_in_help, r=daira
zkbot [Mon, 17 Apr 2017 15:49:37 +0000 (15:49 +0000)]
Auto merge of #2205 - arcalinea:1804_zcash_addresses_in_help, r=daira

Change help text examples to use Zcash addresses

Closes #1804 and #2109

Ensures command line help text addresses are Zcash addresses.

Didn't change the text strings that say bitcoin or btc, leaving that for #2150 to close

Did I get all the addresses?

7 years agoChange regtest port to 18344. Closes #2269.
Simon [Sun, 16 Apr 2017 21:48:04 +0000 (14:48 -0700)]
Change regtest port to 18344.  Closes #2269.

7 years agoAuto merge of #2265 - daira:2263.fix-rpc-error-reporting, r=daira
zkbot [Sun, 16 Apr 2017 16:56:16 +0000 (16:56 +0000)]
Auto merge of #2265 - daira:2263.fix-rpc-error-reporting, r=daira

Fix an error reporting bug due to BrokenPipeError and ConnectionResetError not existing in Python 2

refs #2263

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoAuto merge of #2189 - bitcartel:1.0.7_with_apache_qpid, r=bitcartel
zkbot [Sun, 16 Apr 2017 15:09:19 +0000 (15:09 +0000)]
Auto merge of #2189 - bitcartel:1.0.7_with_apache_qpid, r=bitcartel

Add AMQP 1.0 support via Apache Qpid Proton C++ API 0.17.0

Closes #2188

7 years agoFix proton build issue with debian jessie, as used on CI servers.
Simon [Sun, 16 Apr 2017 07:30:58 +0000 (00:30 -0700)]
Fix proton build issue with debian jessie, as used on CI servers.

Debian 8 stable ships with gcc 4.9.2 and cmake 3.0.2.  Previously
the depends package used CMAKE_CXX_STANDARD to tell cmake to use
C++11, but the option requires cmakes 3.1+.  To resolve the issue
we now update relevant CMakeLists.txt and set CMAKE_CXX_FLAGS.

7 years agoPoll on getblocktemplate result rather than use bare sleep to avoid race condition.
Jay Graber [Sat, 15 Apr 2017 00:31:35 +0000 (17:31 -0700)]
Poll on getblocktemplate result rather than use bare sleep to avoid race condition.

7 years agoFix an error reporting bug due to BrokenPipeError and ConnectionResetError not existi...
Daira Hopwood [Fri, 14 Apr 2017 20:40:30 +0000 (21:40 +0100)]
Fix an error reporting bug due to BrokenPipeError and ConnectionResetError not existing in Python 2.
refs #2263

Signed-off-by: Daira Hopwood <[email protected]>
7 years ago[Direct master commit] Fix a release snafu in debian version string.
Nathan Wilcox [Fri, 14 Apr 2017 03:24:28 +0000 (20:24 -0700)]
[Direct master commit] Fix a release snafu in debian version string.

7 years agoAuto merge of #2260 - nathan-at-least:release-v1.0.8-1, r=nathan-at-least
zkbot [Fri, 14 Apr 2017 01:12:14 +0000 (01:12 +0000)]
Auto merge of #2260 - nathan-at-least:release-v1.0.8-1, r=nathan-at-least

Release v1.0.8 1

7 years agoFix the previous incorrect fix to the manpage.
Nathan Wilcox [Fri, 14 Apr 2017 01:10:19 +0000 (18:10 -0700)]
Fix the previous incorrect fix to the manpage.

7 years agoUndo a documentation error due to an automated tool.
Nathan Wilcox [Fri, 14 Apr 2017 01:08:12 +0000 (18:08 -0700)]
Undo a documentation error due to an automated tool.

7 years agoFix a release-process.md bug; commit results changelog + debian updates.
Nathan Wilcox [Fri, 14 Apr 2017 00:48:08 +0000 (17:48 -0700)]
Fix a release-process.md bug; commit results changelog + debian updates.

7 years agoCommit the changes from gen-manpages.sh, except manually tweak the version strings.
Nathan Wilcox [Fri, 14 Apr 2017 00:39:36 +0000 (17:39 -0700)]
Commit the changes from gen-manpages.sh, except manually tweak the version strings.

7 years agoBump version numbers for v1.0.8-1.
Nathan Wilcox [Fri, 14 Apr 2017 00:10:32 +0000 (17:10 -0700)]
Bump version numbers for v1.0.8-1.

7 years agoAuto merge of #2259 - nathan-at-least:simplify-joinsplit-priority2, r=ebfull
zkbot [Thu, 13 Apr 2017 22:54:55 +0000 (22:54 +0000)]
Auto merge of #2259 - nathan-at-least:simplify-joinsplit-priority2, r=ebfull

simplify joinsplit priority

7 years agoAdd check for JoinSplit priority as calculated by CCoinsViewCache::GetPriority.
Daira Hopwood [Thu, 13 Apr 2017 20:53:33 +0000 (21:53 +0100)]
Add check for JoinSplit priority as calculated by CCoinsViewCache::GetPriority.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoSimplify JoinSplit priority calculation. refs 1896
Daira Hopwood [Thu, 13 Apr 2017 21:40:20 +0000 (22:40 +0100)]
Simplify JoinSplit priority calculation. refs 1896

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoAdd unit test for security issue 2017-04-11.a
str4d [Thu, 13 Apr 2017 14:03:29 +0000 (02:03 +1200)]
Add unit test for security issue 2017-04-11.a

7 years agoUpdate tests to check actual infinity as well as INF_FEERATE
str4d [Wed, 12 Apr 2017 23:15:57 +0000 (11:15 +1200)]
Update tests to check actual infinity as well as INF_FEERATE

7 years agoDon't rely on a finite upper bound on fee rate or priority.
Daira Hopwood [Sun, 9 Apr 2017 22:29:10 +0000 (23:29 +0100)]
Don't rely on a finite upper bound on fee rate or priority.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoDelete old protocol version constants and simplify code that used them.
Daira Hopwood [Sun, 9 Apr 2017 12:19:48 +0000 (13:19 +0100)]
Delete old protocol version constants and simplify code that used them.
fixes #2244

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoAuto merge of #2241 - str4d:2238-benchmark-timeouts, r=ageis
zkbot [Fri, 7 Apr 2017 09:06:41 +0000 (09:06 +0000)]
Auto merge of #2241 - str4d:2238-benchmark-timeouts, r=ageis

Use a larger -rpcclienttimeout for slow performance measurements

Closes #2238.

7 years agoUse a larger -rpcclienttimeout for slow performance measurements
Jack Grigg [Fri, 7 Apr 2017 01:20:13 +0000 (13:20 +1200)]
Use a larger -rpcclienttimeout for slow performance measurements

Closes #2238.

7 years agoUse AtomicTimer for metrics screen thread count
Jack Grigg [Tue, 14 Feb 2017 22:06:35 +0000 (22:06 +0000)]
Use AtomicTimer for metrics screen thread count

7 years agoRemove ChainParams::DefaultMinerThreads
Wladimir J. van der Laan [Fri, 3 Jul 2015 07:13:56 +0000 (09:13 +0200)]
Remove ChainParams::DefaultMinerThreads

No longer relevant after #5957. This hack existed because of another
hack where the numthreads parameter, on regtest, doubled as how many
blocks to generate.

7 years agoUse real number of cores for default -par, ignore virtual cores
Wladimir J. van der Laan [Wed, 1 Jul 2015 15:38:15 +0000 (17:38 +0200)]
Use real number of cores for default -par, ignore virtual cores

To determine the default for `-par`, the number of script verification
threads, use [boost::thread::physical_concurrency()](http://www.boost.org/doc/libs/1_58_0/doc/html/thread/thread_management.html#thread.thread_management.thread.physical_concurrency)
which counts only physical cores, not virtual cores.

Virtual cores are roughly a set of cached registers to avoid context
switches while threading, they cannot actually perform work, so spawning
a verification thread for them could even reduce efficiency and will put
undue load on the system.

Should fix issue #6358, as well as some other reported system overload
issues, especially on Intel processors.

The function was only introduced in boost 1.56, so provide a utility
function `GetNumCores` to fall back for older Boost versions.

7 years agoAuto merge of #2213 - daira:2211.release-1.0.8, r=daira
zkbot [Tue, 28 Mar 2017 01:22:21 +0000 (01:22 +0000)]
Auto merge of #2213 - daira:2211.release-1.0.8, r=daira

2211.release-1.0.8

Release 1.0.8. refs #2211

7 years agoUpdate authors, release notes, and Debian package metadata.
Daira Hopwood [Mon, 27 Mar 2017 20:32:16 +0000 (21:32 +0100)]
Update authors, release notes, and Debian package metadata.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoGenerate man pages.
Daira Hopwood [Mon, 27 Mar 2017 20:27:10 +0000 (21:27 +0100)]
Generate man pages.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoImprovement to release process doc.
Daira Hopwood [Mon, 27 Mar 2017 20:05:10 +0000 (21:05 +0100)]
Improvement to release process doc.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoUpdate version numbers.
Daira Hopwood [Mon, 27 Mar 2017 20:01:18 +0000 (21:01 +0100)]
Update version numbers.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agoAuto merge of #2177 - str4d:2061-tor-ephemeral-hs, r=daira
zkbot [Sun, 26 Mar 2017 02:44:06 +0000 (02:44 +0000)]
Auto merge of #2177 - str4d:2061-tor-ephemeral-hs, r=daira

Tor ephemeral hidden services

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6503 (included to reduce merge conflicts)
- bitcoin/bitcoin#6639
- bitcoin/bitcoin#6643
- bitcoin/bitcoin#7090
- bitcoin/bitcoin#7035
- bitcoin/bitcoin#7170
- bitcoin/bitcoin#7218 (non-QT part)
- bitcoin/bitcoin#7313
- bitcoin/bitcoin#7438
- bitcoin/bitcoin#7553
- bitcoin/bitcoin#7637
- bitcoin/bitcoin#7683
- bitcoin/bitcoin#7813
- bitcoin/bitcoin#7703
- bitcoin/bitcoin#8203
- bitcoin/bitcoin#9004
- bitcoin/bitcoin#9234
- bitcoin/bitcoin#9911 (partial)

Closes #2061.

7 years agoAuto merge of #2203 - arcalinea:2142_security_log_message, r=daira
zkbot [Sun, 26 Mar 2017 01:36:24 +0000 (01:36 +0000)]
Auto merge of #2203 - arcalinea:2142_security_log_message, r=daira

Add message directing users to security guide

Addresses #2142, which was blocking on updates to zcash/support/security.html. That page has now been added, so this message directing users to the site can be included.

It displays in the zcash-cli --help and --version message text, and on the zcashd metrics screen.

7 years agotorcontrol: Log invalid parameters in Tor reply strings where meaningful
Jack Grigg [Sun, 26 Mar 2017 01:35:13 +0000 (14:35 +1300)]
torcontrol: Log invalid parameters in Tor reply strings where meaningful

7 years agoLine-wrap privacy notice. Use <> around URL and end sentence with '.'.
Daira Hopwood [Sun, 26 Mar 2017 01:08:29 +0000 (02:08 +0100)]
Line-wrap privacy notice. Use <> around URL and end sentence with '.'.
Include privacy notice in help text for zcashd -help.

Signed-off-by: Daira Hopwood <[email protected]>
7 years agotorcontrol: Check for reading errors in ReadBinaryFile
Jack Grigg [Sun, 26 Mar 2017 00:53:13 +0000 (13:53 +1300)]
torcontrol: Check for reading errors in ReadBinaryFile

This ensures that ReadBinaryFile never returns exactly TOR_COOKIE_SIZE bytes if
the file was larger than that.

7 years agoAdd --disable-proton flag to build.sh. Proton has build/linker issues with gcc 4...
Simon [Sat, 25 Mar 2017 16:03:22 +0000 (09:03 -0700)]
Add --disable-proton flag to build.sh.  Proton has build/linker issues with gcc 4.9.2 and requires gcc 5.x.

7 years agoAdd AMQP 1.0 support via Apache Qpid Proton C++ API 0.17.0
Simon [Thu, 9 Mar 2017 00:19:54 +0000 (16:19 -0800)]
Add AMQP 1.0 support via Apache Qpid Proton C++ API 0.17.0

7 years agotorcontrol: Fix ParseTorReplyMapping
Jack Grigg [Sat, 25 Mar 2017 11:35:13 +0000 (00:35 +1300)]
torcontrol: Fix ParseTorReplyMapping

- Ignore remaining input if it is an OptArguments
- Correctly handle escapes

7 years agotorcontrol: Add unit tests for Tor reply parsers
Jack Grigg [Sat, 25 Mar 2017 07:17:37 +0000 (20:17 +1300)]
torcontrol: Add unit tests for Tor reply parsers

7 years agotorcontrol: Improve comments
Jack Grigg [Sat, 25 Mar 2017 07:13:18 +0000 (20:13 +1300)]
torcontrol: Improve comments

7 years agoMake some global variables less-global (static)
Pavel Janík [Wed, 8 Mar 2017 21:13:15 +0000 (22:13 +0100)]
Make some global variables less-global (static)

7 years agoPrevent -Wshadow warnings with gcc versions 4.8.5, 5.3.1 and 6.2.1.
Pavel Janík [Fri, 3 Mar 2017 15:20:33 +0000 (16:20 +0100)]
Prevent -Wshadow warnings with gcc versions 4.8.5, 5.3.1 and 6.2.1.

Zcash: partial (ignoring src/test/script_tests.cpp due to merge conflicts)

7 years agotorcontrol: Explicitly request RSA1024 private key
Wladimir J. van der Laan [Mon, 28 Nov 2016 16:13:51 +0000 (17:13 +0100)]
torcontrol: Explicitly request RSA1024 private key

When generating a new service key, explicitly request a RSA1024 one.

The bitcoin P2P protocol has no support for the longer hidden service names
that will come with ed25519 keys, until it does, we depend on the old
hidden service type so make this explicit.

See #9214.

7 years agoClarify `listenonion`
unsystemizer [Mon, 24 Oct 2016 07:49:46 +0000 (15:49 +0800)]
Clarify `listenonion`

> This new feature is enabled by default if Bitcoin Core is listening, and a connection to Tor can be made. It can be configured with the -listenonion, -torcontrol and -torpassword settings. To show verbose debugging information, pass -debug=tor.

But it is correct to say that the feature is enabled *regardless* of whether a connection to Tor can be made.

I propose to clarify that so that users can eliminate these in their logs (when `listen=1` and no Tor).
And I think it's okay to clarify about the `listen` option, because on several occasions when I read this before I always assumed `listening` meant `server=1` which cost me a lot of time in troubleshooting.

```
2016-10-24 06:19:22.551029 tor: Error connecting to Tor control socket
2016-10-24 06:19:22.551700 tor: Not connected to Tor control port 127.0.0.1:9051, trying to reconnect
```

0.12.1

7 years agoClarify documentation for running a tor node
Nathaniel Mahieu [Tue, 14 Jun 2016 22:49:09 +0000 (17:49 -0500)]
Clarify documentation for running a tor node

Previous wording suggested that no additional setup was required for a
tor hidden service to be created.

7 years agotor: Change auth order to only use HASHEDPASSWORD if -torpassword
Wladimir J. van der Laan [Thu, 17 Mar 2016 11:49:16 +0000 (12:49 +0100)]
tor: Change auth order to only use HASHEDPASSWORD if -torpassword

Change authentication order to make it more clear (see #7700).

- If the `-torpassword` option is provided, force use of
  `HASHEDPASSWORD` auth.

- Give error message if `-torpassword` provided, but
  `HASHEDPASSWORD` auth is not available.

- Give error message if only `HASHEDPASSWORD` available, but
  `-torpassword` not given.

7 years ago[doc] Update port in tor.md
Adam Brown [Tue, 29 Mar 2016 18:16:16 +0000 (15:16 -0300)]
[doc] Update port in tor.md

Tor Browser Bundle spawns the Tor process and listens on port 9150, it doesn't randomly pick a port.

[ci skip]
(cherry picked from commit 1b63cf98347b2a62915425576930f55c2126c2ff)

7 years agoFix torcontrol.cpp unused private field warning
Jonas Schnelli [Mon, 14 Mar 2016 15:07:42 +0000 (16:07 +0100)]
Fix torcontrol.cpp unused private field warning

7 years agoFix memleak in TorController [rework]
Wladimir J. van der Laan [Thu, 3 Mar 2016 12:28:07 +0000 (13:28 +0100)]
Fix memleak in TorController [rework]

It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

7 years agoRemove vfReachable and modify IsReachable to only use vfLimited.
Patrick Strateman [Thu, 18 Feb 2016 06:44:32 +0000 (22:44 -0800)]
Remove vfReachable and modify IsReachable to only use vfLimited.

We do not know that a class of Network is reachable, only that it is not.

7 years agoDecide eviction group ties based on time.
Gregory Maxwell [Mon, 23 Nov 2015 03:48:54 +0000 (03:48 +0000)]
Decide eviction group ties based on time.

This corrects a bug the case of tying group size where the code may
 fail to select the group with the newest member. Since newest time
 is the final selection criteria, failing to break ties on it
 on the step before can undermine the final selection.

Tied netgroups are very common.

7 years agoDo not absolutely protect local peers from eviction.
Gregory Maxwell [Thu, 28 Jan 2016 22:44:14 +0000 (22:44 +0000)]
Do not absolutely protect local peers from eviction.

With automatic tor HS support in place we should probably not be providing
 absolute protection for local peers, since HS inbound could be used to
 attack pretty easily.  Instead, this counts on the latency metric inside
 AttemptToEvictConnection to privilege actually local peers.

7 years agoFixing typos on security-check.py and torcontrol.cpp
calebogden [Fri, 8 Jan 2016 21:31:42 +0000 (13:31 -0800)]
Fixing typos on security-check.py and torcontrol.cpp

7 years agotorcontrol debug: Change to a blanket message that covers both cases
MarcoFalke [Tue, 15 Dec 2015 16:03:08 +0000 (17:03 +0100)]
torcontrol debug: Change to a blanket message that covers both cases

7 years agotests: Disable Tor interaction
Wladimir J. van der Laan [Fri, 4 Dec 2015 12:24:12 +0000 (13:24 +0100)]
tests: Disable Tor interaction

This is unnecessary during the current tests (any test for Tor
interaction can explicitly enable it) and interferes with the proxy
test.

7 years agotorcontrol: only output disconnect if -debug=tor
Daniel Cousens [Tue, 17 Nov 2015 01:10:28 +0000 (12:10 +1100)]
torcontrol: only output disconnect if -debug=tor

7 years agoConnect to Tor hidden services by default
Peter Todd [Tue, 24 Nov 2015 15:27:38 +0000 (10:27 -0500)]
Connect to Tor hidden services by default

Adds 127.0.0.1:9050 for the .onion proxy if we can succesfully connect
to the control port.

Natural followup to creating hidden services automatically.

7 years ago[doc] [tor] Clarify when to use bind
MarcoFalke [Sun, 6 Sep 2015 15:54:41 +0000 (17:54 +0200)]
[doc] [tor] Clarify when to use bind

c.f. #6585

7 years agodoc: update docs for Tor listening
Wladimir J. van der Laan [Wed, 11 Nov 2015 14:08:38 +0000 (15:08 +0100)]
doc: update docs for Tor listening

- add new data directory files for 0.12 to doc/files.md
- mention torcontrol in doc/tor.md

7 years agotorcontrol improvements and fixes
Wladimir J. van der Laan [Tue, 8 Sep 2015 15:48:45 +0000 (17:48 +0200)]
torcontrol improvements and fixes

- Force AUTHCOOKIE size to be 32 bytes: This provides protection against
  an attack where a process pretends to be Tor and uses the cookie
  authentication method to nab arbitrary files such as the
  wallet
- torcontrol logging
- fix cookie auth
- add HASHEDPASSWORD auth, fix fd leak when fwrite() fails
- better error reporting when cookie file is not ok
- better init/shutdown flow
- stop advertizing service when disconnected from tor control port
- COOKIE->SAFECOOKIE auth

7 years agoBetter error message if Tor version too old
Peter Todd [Thu, 27 Aug 2015 04:43:18 +0000 (21:43 -0700)]
Better error message if Tor version too old

7 years agonet: Automatically create hidden service, listen on Tor
Wladimir J. van der Laan [Tue, 25 Aug 2015 18:12:08 +0000 (20:12 +0200)]
net: Automatically create hidden service, listen on Tor

Starting with Tor version 0.2.7.1 it is possible, through Tor's control socket
API, to create and destroy 'ephemeral' hidden services programmatically.
https://stem.torproject.org/api/control.html#stem.control.Controller.create_ephemeral_hidden_service

This means that if Tor is running (and proper authorization is available),
bitcoin automatically creates a hidden service to listen on, without user
manual configuration. This will positively affect the number of available
.onion nodes.

- When the node is started, connect to Tor through control socket
- Send `ADD_ONION` command
- First time:
    - Make it create a hidden service key
    - Save the key in the data directory for later usage
- Make it redirect port 8333 to the local port 8333 (or whatever port we're listening on).
- Keep control socket connection open for as long node is running. The hidden service will
  (by default) automatically go away when the connection is closed.

7 years agoConsolidate individual references to the current maximum peer connection
Matt Quinn [Sat, 1 Aug 2015 17:41:21 +0000 (10:41 -0700)]
Consolidate individual references to the current maximum peer connection
value of 125 into a single constant declaration.

7 years agoAuto merge of #2176 - str4d:1593-libevent, r=bitcartel
zkbot [Sat, 25 Mar 2017 04:52:16 +0000 (04:52 +0000)]
Auto merge of #2176 - str4d:1593-libevent, r=bitcartel

libevent-based http server

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#5677
- bitcoin/bitcoin#6695
- bitcoin/bitcoin#6899
- bitcoin/bitcoin#7016
- bitcoin/bitcoin#7964
- bitcoin/bitcoin#8722
- bitcoin/bitcoin#8730
- bitcoin/bitcoin#9073
- bitcoin/bitcoin#9265
- bitcoin/bitcoin#9387
- bitcoin/bitcoin#9471
- bitcoin/bitcoin#9647
- bitcoin/bitcoin#9903
- bitcoin/bitcoin#6640
- bitcoin/bitcoin#8139
- bitcoin/bitcoin#8839

Closes #1593 and #1856.

7 years agoFix typo
Jack Grigg [Sat, 25 Mar 2017 04:40:27 +0000 (17:40 +1300)]
Fix typo

This page took 0.071632 seconds and 4 git commands to generate.