]> Git Repo - VerusCoin.git/commit - src/script/interpreter.h
Add consensus branch ID parameter to SignatureHash, remove SigVersion parameter
authorJack Grigg <[email protected]>
Fri, 2 Feb 2018 01:49:42 +0000 (01:49 +0000)
committerJack Grigg <[email protected]>
Tue, 20 Feb 2018 04:22:20 +0000 (04:22 +0000)
commitbe12669982b86313e76500908400bcc98f8c2a97
treec455f447100b5b1c7cc8dc22cdf14d0e03d73d93
parent6514771a44cc069f4fc179babbd6a5bbc7dc0c43
Add consensus branch ID parameter to SignatureHash, remove SigVersion parameter

We do not need to be able to calculate multiple SignatureHash versions for a
single transaction format; instead, we use the transaction format to determine
the SigVersion.

The consensus branch ID *does* need to be passed in from the outside, as only
the caller knows the context in which the SignatureHash is being calculated
(ie. mempool acceptance vs. block validation).

JoinSplit signature verification has been moved into ContextualCheckTransaction,
where the consensus branch ID can be obtained.

The argument to the sign command for zcash-tx has been modified to take a height
in addition to the optional sigtype flags.
26 files changed:
src/bitcoin-tx.cpp
src/gtest/test_checktransaction.cpp
src/gtest/test_validation.cpp
src/main.cpp
src/main.h
src/miner.cpp
src/rpcrawtransaction.cpp
src/script/interpreter.cpp
src/script/interpreter.h
src/script/sign.cpp
src/script/sign.h
src/script/zcashconsensus.cpp
src/test/DoS_tests.cpp
src/test/data/bitcoin-util-test.json
src/test/multisig_tests.cpp
src/test/script_P2SH_tests.cpp
src/test/script_tests.cpp
src/test/sighash_tests.cpp
src/test/transaction_tests.cpp
src/utiltest.cpp
src/wallet/asyncrpcoperation_sendmany.cpp
src/wallet/asyncrpcoperation_sendmany.h
src/wallet/asyncrpcoperation_shieldcoinbase.cpp
src/wallet/rpcwallet.cpp
src/wallet/wallet.cpp
src/zcbenchmarks.cpp
This page took 0.033788 seconds and 4 git commands to generate.