]> Git Repo - VerusCoin.git/commit
Auto merge of #3669 - charlieok:init_win_networking_in_test_setup, r=str4d
authorHomu <[email protected]>
Thu, 15 Nov 2018 20:34:11 +0000 (12:34 -0800)
committerHomu <[email protected]>
Thu, 15 Nov 2018 20:34:11 +0000 (12:34 -0800)
commitae49175cd4fa9e751f07e4551dcfc42c4e9d5731
treea79dcb06db09e2722e0292bcc88e5adc403681df
parent570e09ea5983e295820ebd2e20ae80644a9ac134
parentefc2b22465a527b8176926713831edc807cd546d
Auto merge of #3669 - charlieok:init_win_networking_in_test_setup, r=str4d

Add a call to SetupNetworking in BasicTestingSetup

In issue https://github.com/zcash/zcash/issues/3668 , the error code returned by `getaddrinfo_a` (10093) is `WSANOTINITIALISED`:

> Successful WSAStartup not yet performed.  Either the application has not called WSAStartup or WSAStartup  failed. The application may be accessing a socket that the current  active task does not own (that is, trying to share a socket between  tasks), or WSACleanup has been called too many times.

https://docs.microsoft.com/en-us/windows/desktop/winsock/windows-sockets-error-codes-2

`WSAStartup` is called from the `SetupNetworking` function in `util.cpp`, but `SetupNetworking` was not being called during test setup. This pull request adds that call.

Here is a gitlab pipeline running tests in the `test_bitcoin.exe` executable before this change:
https://gitlab.com/charlieok/zcash/pipelines/36483478

...and here is the same set of tests run after this change:
https://gitlab.com/charlieok/zcash/pipelines/36485098
This page took 0.023169 seconds and 4 git commands to generate.