]> Git Repo - VerusCoin.git/commit - src/wallet/rpcwallet.cpp
`getrawchangeaddress` should fail when keypool exhausted
authorWladimir J. van der Laan <[email protected]>
Mon, 16 Jun 2014 12:45:32 +0000 (14:45 +0200)
committerWladimir J. van der Laan <[email protected]>
Fri, 11 Jul 2014 13:24:29 +0000 (15:24 +0200)
commit6c37f7fd78832442a26e56bd0787974927df4fb2
tree9c4138c7e53bbd4607a13de9169dd2d0dabee6be
parent6ad2c2402e694d0052f8f1688181a80fe3eef2e7
`getrawchangeaddress` should fail when keypool exhausted

An user on IRC reported an issue where `getrawchangeaddress`
keeps returning a single address when the keypool is exhausted.
In my opinion this is strange behaviour.

- Change CReserveKey to fail when running out of keys in the keypool.
- Make `getrawchangeaddress` return RPC_WALLET_KEYPOOL_RAN_OUT when
  unable to create an address.
- Add a Python RPC test for checking the keypool behaviour in combination
  with encrypted wallets.
qa/rpc-tests/keypool.py [new file with mode: 0755]
src/miner.cpp
src/rpcwallet.cpp
src/wallet.cpp
This page took 0.036989 seconds and 4 git commands to generate.