From: Diana Craciun Date: Fri, 16 Oct 2020 09:32:32 +0000 (+0300) Subject: vfio/fsl-mc: fix the return of the uninitialized variable ret X-Git-Url: https://repo.jachan.dev/J-linux.git/commitdiff_plain/822e1a90afff61826252a65e574e940c0038055c vfio/fsl-mc: fix the return of the uninitialized variable ret The vfio_fsl_mc_reflck_attach function may return, on success path, an uninitialized variable. Fix the problem by initializing the return variable to 0. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: f2ba7e8c947b ("vfio/fsl-mc: Added lock support in preparation for interrupt handling") Reported-by: Colin Ian King Signed-off-by: Diana Craciun Signed-off-by: Alex Williamson --- diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c index 80fc7f4ed343..0113a980f974 100644 --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c @@ -58,7 +58,7 @@ static struct vfio_fsl_mc_reflck *vfio_fsl_mc_reflck_alloc(void) static int vfio_fsl_mc_reflck_attach(struct vfio_fsl_mc_device *vdev) { - int ret; + int ret = 0; mutex_lock(&reflck_lock); if (is_fsl_mc_bus_dprc(vdev->mc_dev)) {