RDMA/bnxt_re: Fix error recovery sequence

RDMA/bnxt_re: Fix error recovery sequence

Fixed to return ENXIO from __send_message_basic_sanity()
to indicate that device is in error state. In the case of
ERR_DEVICE_DETACHED state, the driver should not post the
commands to the firmware as it will time out eventually.

Removed bnxt_re_modify_qp() call from bnxt_re_dev_stop()
as it is a no-op.

Fixes: cc5b9b48d447 ("RDMA/bnxt_re: Recover the device when FW error is detected")
Signed-off-by: Kalesh AP <[email protected]>
Signed-off-by: Kashyap Desai <[email protected]>
Link: https://patch.msgid.link/[email protected]
Reviewed-by: Selvin Xavier <[email protected]>
Signed-off-by: Leon Romanovsky <[email protected]>