]> Git Repo - J-linux.git/blobdiff - drivers/fpga/fpga-bridge.c
Merge branch 'linus' into x86/urgent
[J-linux.git] / drivers / fpga / fpga-bridge.c
index 9651aa56244a562e0daadb8fd2de230ac7d99e9a..24b8f98b73ec69019a5421258c57123d8034cadf 100644 (file)
@@ -1,19 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * FPGA Bridge Framework Driver
  *
  *  Copyright (C) 2013-2016 Altera Corporation, All Rights Reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program.  If not, see <http://www.gnu.org/licenses/>.
+ *  Copyright (C) 2017 Intel Corporation
  */
 #include <linux/fpga/fpga-bridge.h>
 #include <linux/idr.h>
@@ -70,32 +60,13 @@ int fpga_bridge_disable(struct fpga_bridge *bridge)
 }
 EXPORT_SYMBOL_GPL(fpga_bridge_disable);
 
-/**
- * of_fpga_bridge_get - get an exclusive reference to a fpga bridge
- *
- * @np: node pointer of a FPGA bridge
- * @info: fpga image specific information
- *
- * Return fpga_bridge struct if successful.
- * Return -EBUSY if someone already has a reference to the bridge.
- * Return -ENODEV if @np is not a FPGA Bridge.
- */
-struct fpga_bridge *of_fpga_bridge_get(struct device_node *np,
-                                      struct fpga_image_info *info)
-
+static struct fpga_bridge *__fpga_bridge_get(struct device *dev,
+                                            struct fpga_image_info *info)
 {
-       struct device *dev;
        struct fpga_bridge *bridge;
        int ret = -ENODEV;
 
-       dev = class_find_device(fpga_bridge_class, NULL, np,
-                               fpga_bridge_of_node_match);
-       if (!dev)
-               goto err_dev;
-
        bridge = to_fpga_bridge(dev);
-       if (!bridge)
-               goto err_dev;
 
        bridge->info = info;
 
@@ -117,8 +88,59 @@ err_dev:
        put_device(dev);
        return ERR_PTR(ret);
 }
+
+/**
+ * of_fpga_bridge_get - get an exclusive reference to a fpga bridge
+ *
+ * @np: node pointer of a FPGA bridge
+ * @info: fpga image specific information
+ *
+ * Return fpga_bridge struct if successful.
+ * Return -EBUSY if someone already has a reference to the bridge.
+ * Return -ENODEV if @np is not a FPGA Bridge.
+ */
+struct fpga_bridge *of_fpga_bridge_get(struct device_node *np,
+                                      struct fpga_image_info *info)
+{
+       struct device *dev;
+
+       dev = class_find_device(fpga_bridge_class, NULL, np,
+                               fpga_bridge_of_node_match);
+       if (!dev)
+               return ERR_PTR(-ENODEV);
+
+       return __fpga_bridge_get(dev, info);
+}
 EXPORT_SYMBOL_GPL(of_fpga_bridge_get);
 
+static int fpga_bridge_dev_match(struct device *dev, const void *data)
+{
+       return dev->parent == data;
+}
+
+/**
+ * fpga_bridge_get - get an exclusive reference to a fpga bridge
+ * @dev:       parent device that fpga bridge was registered with
+ * @info:      fpga manager info
+ *
+ * Given a device, get an exclusive reference to a fpga bridge.
+ *
+ * Return: fpga manager struct or IS_ERR() condition containing error code.
+ */
+struct fpga_bridge *fpga_bridge_get(struct device *dev,
+                                   struct fpga_image_info *info)
+{
+       struct device *bridge_dev;
+
+       bridge_dev = class_find_device(fpga_bridge_class, NULL, dev,
+                                      fpga_bridge_dev_match);
+       if (!bridge_dev)
+               return ERR_PTR(-ENODEV);
+
+       return __fpga_bridge_get(bridge_dev, info);
+}
+EXPORT_SYMBOL_GPL(fpga_bridge_get);
+
 /**
  * fpga_bridge_put - release a reference to a bridge
  *
@@ -206,7 +228,7 @@ void fpga_bridges_put(struct list_head *bridge_list)
 EXPORT_SYMBOL_GPL(fpga_bridges_put);
 
 /**
- * fpga_bridges_get_to_list - get a bridge, add it to a list
+ * of_fpga_bridge_get_to_list - get a bridge, add it to a list
  *
  * @np: node pointer of a FPGA bridge
  * @info: fpga image specific information
@@ -216,14 +238,44 @@ EXPORT_SYMBOL_GPL(fpga_bridges_put);
  *
  * Return 0 for success, error code from of_fpga_bridge_get() othewise.
  */
-int fpga_bridge_get_to_list(struct device_node *np,
+int of_fpga_bridge_get_to_list(struct device_node *np,
+                              struct fpga_image_info *info,
+                              struct list_head *bridge_list)
+{
+       struct fpga_bridge *bridge;
+       unsigned long flags;
+
+       bridge = of_fpga_bridge_get(np, info);
+       if (IS_ERR(bridge))
+               return PTR_ERR(bridge);
+
+       spin_lock_irqsave(&bridge_list_lock, flags);
+       list_add(&bridge->node, bridge_list);
+       spin_unlock_irqrestore(&bridge_list_lock, flags);
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(of_fpga_bridge_get_to_list);
+
+/**
+ * fpga_bridge_get_to_list - given device, get a bridge, add it to a list
+ *
+ * @dev: FPGA bridge device
+ * @info: fpga image specific information
+ * @bridge_list: list of FPGA bridges
+ *
+ * Get an exclusive reference to the bridge and and it to the list.
+ *
+ * Return 0 for success, error code from fpga_bridge_get() othewise.
+ */
+int fpga_bridge_get_to_list(struct device *dev,
                            struct fpga_image_info *info,
                            struct list_head *bridge_list)
 {
        struct fpga_bridge *bridge;
        unsigned long flags;
 
-       bridge = of_fpga_bridge_get(np, info);
+       bridge = fpga_bridge_get(dev, info);
        if (IS_ERR(bridge))
                return PTR_ERR(bridge);
 
@@ -266,28 +318,29 @@ static struct attribute *fpga_bridge_attrs[] = {
 ATTRIBUTE_GROUPS(fpga_bridge);
 
 /**
- * fpga_bridge_register - register a fpga bridge driver
+ * fpga_bridge_create - create and initialize a struct fpga_bridge
  * @dev:       FPGA bridge device from pdev
  * @name:      FPGA bridge name
  * @br_ops:    pointer to structure of fpga bridge ops
  * @priv:      FPGA bridge private data
  *
- * Return: 0 for success, error code otherwise.
+ * Return: struct fpga_bridge or NULL
  */
-int fpga_bridge_register(struct device *dev, const char *name,
-                        const struct fpga_bridge_ops *br_ops, void *priv)
+struct fpga_bridge *fpga_bridge_create(struct device *dev, const char *name,
+                                      const struct fpga_bridge_ops *br_ops,
+                                      void *priv)
 {
        struct fpga_bridge *bridge;
        int id, ret = 0;
 
        if (!name || !strlen(name)) {
                dev_err(dev, "Attempt to register with no name!\n");
-               return -EINVAL;
+               return NULL;
        }
 
        bridge = kzalloc(sizeof(*bridge), GFP_KERNEL);
        if (!bridge)
-               return -ENOMEM;
+               return NULL;
 
        id = ida_simple_get(&fpga_bridge_ida, 0, 0, GFP_KERNEL);
        if (id < 0) {
@@ -303,44 +356,67 @@ int fpga_bridge_register(struct device *dev, const char *name,
        bridge->priv = priv;
 
        device_initialize(&bridge->dev);
+       bridge->dev.groups = br_ops->groups;
        bridge->dev.class = fpga_bridge_class;
        bridge->dev.parent = dev;
        bridge->dev.of_node = dev->of_node;
        bridge->dev.id = id;
-       dev_set_drvdata(dev, bridge);
 
        ret = dev_set_name(&bridge->dev, "br%d", id);
        if (ret)
                goto error_device;
 
-       ret = device_add(&bridge->dev);
-       if (ret)
-               goto error_device;
-
-       of_platform_populate(dev->of_node, NULL, NULL, dev);
-
-       dev_info(bridge->dev.parent, "fpga bridge [%s] registered\n",
-                bridge->name);
-
-       return 0;
+       return bridge;
 
 error_device:
        ida_simple_remove(&fpga_bridge_ida, id);
 error_kfree:
        kfree(bridge);
 
-       return ret;
+       return NULL;
 }
-EXPORT_SYMBOL_GPL(fpga_bridge_register);
+EXPORT_SYMBOL_GPL(fpga_bridge_create);
+
+/**
+ * fpga_bridge_free - free a fpga bridge and its id
+ * @bridge:    FPGA bridge struct created by fpga_bridge_create
+ */
+void fpga_bridge_free(struct fpga_bridge *bridge)
+{
+       ida_simple_remove(&fpga_bridge_ida, bridge->dev.id);
+       kfree(bridge);
+}
+EXPORT_SYMBOL_GPL(fpga_bridge_free);
 
 /**
- * fpga_bridge_unregister - unregister a fpga bridge driver
- * @dev: FPGA bridge device from pdev
+ * fpga_bridge_register - register a fpga bridge
+ * @bridge:    FPGA bridge struct created by fpga_bridge_create
+ *
+ * Return: 0 for success, error code otherwise.
  */
-void fpga_bridge_unregister(struct device *dev)
+int fpga_bridge_register(struct fpga_bridge *bridge)
 {
-       struct fpga_bridge *bridge = dev_get_drvdata(dev);
+       struct device *dev = &bridge->dev;
+       int ret;
 
+       ret = device_add(dev);
+       if (ret)
+               return ret;
+
+       of_platform_populate(dev->of_node, NULL, NULL, dev);
+
+       dev_info(dev->parent, "fpga bridge [%s] registered\n", bridge->name);
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(fpga_bridge_register);
+
+/**
+ * fpga_bridge_unregister - unregister and free a fpga bridge
+ * @bridge:    FPGA bridge struct created by fpga_bridge_create
+ */
+void fpga_bridge_unregister(struct fpga_bridge *bridge)
+{
        /*
         * If the low level driver provides a method for putting bridge into
         * a desired state upon unregister, do it.
@@ -356,8 +432,7 @@ static void fpga_bridge_dev_release(struct device *dev)
 {
        struct fpga_bridge *bridge = to_fpga_bridge(dev);
 
-       ida_simple_remove(&fpga_bridge_ida, bridge->dev.id);
-       kfree(bridge);
+       fpga_bridge_free(bridge);
 }
 
 static int __init fpga_bridge_dev_init(void)
@@ -381,7 +456,7 @@ static void __exit fpga_bridge_dev_exit(void)
 }
 
 MODULE_DESCRIPTION("FPGA Bridge Driver");
-MODULE_AUTHOR("Alan Tull <atull@opensource.altera.com>");
+MODULE_AUTHOR("Alan Tull <atull@kernel.org>");
 MODULE_LICENSE("GPL v2");
 
 subsys_initcall(fpga_bridge_dev_init);
This page took 0.037697 seconds and 4 git commands to generate.